Refactor WikiUserEmailChecker service #1043
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalieper
force-pushed
the
refactorGDPR-script
branch
from
a6d32f4 to
3cd57d9
Compare
outdooracorn
approved these changes
Jan 22, 2026
Member
outdooracorn
left a comment
outdooracorn
left a comment
There was a problem hiding this comment.
LGTM! Left some minor nitpick comments.
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
Comment on lines
32
to
34
| WHERE TABLE_SCHEMA LIKE 'mwdb\_%' | ||
| WHERE TABLE_SCHEMA LIKE 'mwdb_%' | ||
| AND TABLE_NAME LIKE '%_user' |
Member
There was a problem hiding this comment.
Blah! Looks like the GitHub suggest feature messed up. 🥲 Sorry about that!
Member
|
The PR title doesn't seem quite right to me. How about "Refactor WikiUserEmailChecker service"? It would also be good to say why you made this refactor. What are the advantages? And a |
rosalieper
changed the title
Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
rosalieper
force-pushed
the
refactorGDPR-script
branch
from
f9f399b to
a57277f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on T415017 I noticed that the
WikiUserEmailCheckertook a longer time to run after passinguser_emailto a function likeLOWERin the query. This refactoring reduces the number of query calls we make in other to improve performance.Bug: T415017