This repository was archived by the owner on Mar 17, 2020. It is now read-only.
Add calculateBodyHash() to replace calculateBodyMac()#33
Open
jcwilson wants to merge 1 commit intowealdtech:developfrom
jcwilson:bodyhash
Open
Add calculateBodyHash() to replace calculateBodyMac()#33jcwilson wants to merge 1 commit intowealdtech:developfrom jcwilson:bodyhash
jcwilson wants to merge 1 commit intowealdtech:developfrom
jcwilson:bodyhash
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The content payload hash should not be dependent on the user's credentials. It's a simple message digest.
This is just the first step in remedying the situation. The rest of the Client and Server code and the tests should be updated to reflect the change.
This is a breaking change that should be messaged out to users of the library. Without it though, clients using this library cannot communicate to servers running other implementations of the server code (and vice versa).