Update ring-jakarta-servlet dependency version and add web.xml for versions 6.0 and 6.1#225
Update ring-jakarta-servlet dependency version and add web.xml for versions 6.0 and 6.1#225waynedyck wants to merge 3 commits intoweavejester:masterfrom
Conversation
|
Thanks for the PR. Can you ensure that the subject line of the commit messages is 50 characters or less, and the body of the commit wraps at 72 characters? |
These are required for Tomcat versions 10.1 and 11. The default-servlet-version is bumped to "6.0" as Tomcat 10.1 is the first version utilizing the shift from javax.* to jakarta.* package names.
Done. |
|
Perfect. And just to confirm - have you tested this change? Does it work with Tomcat? |
Yes. I just tested the changes again on an application with The current version, |
|
@weavejester Do you require anything else from me at this point regarding the pull request? |
To have a deployed version of [Update ring-jakarta-servlet dependency version and add web.xml for versions 6.0 and 6.1 by waynedyck · Pull Request weavejester#225 · weavejester/lein-ring · GitHub](weavejester#225)
3 participants
This pull request also incorporates the updates in pull request #224 from @madoxas.
With the shift from javax.* to jakarta.* package names, the minimum supported Tomcat version is 10.1 at the moment and it uses servlet version 6.0. I also added the web.xml servlet definition for Tomcat version 11.