Skip to content

A DataView is returned instead of an ArrayBuffer in M50. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beaufortfrancois wants to merge 1 commit into
base: master
Choose a base branch
from
Open

A DataView is returned instead of an ArrayBuffer in M50. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,9 @@ <h2 id="z"></h2>

// so now we have the characteristic and we can keep reading data...
function readZ() {
char.readValue().then(buffer => {
var data = new DataView(buffer);
char.readValue().then(data => {
// In Chrome 50+, a DataView is returned instead of an ArrayBuffer.
data = data.buffer ? data : new DataView(data);

var z = data.getUint8(5) << 8 | data.getUint8(4);
if (z > 32767) { // overflow
Expand Down