feat: Auto retry judge and build #1768
Conversation
Signed-off-by: Wangyan <topshihun@foxmail.com>
topshihun
force-pushed
the
feat/task-auto-retry
branch
from
c84b191 to
3fb3775
Compare
topshihun
changed the title
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This PR implements an automatic retry mechanism for build tasks in the orion-server. It introduces logic to determine whether a failed build should be automatically retried based on exit codes (signal interruptions) or output keywords (network/HTTP errors), with a maximum of 3 retry attempts per build.
Key Changes:
- New
AutoRetryJudgercomponent to evaluate retry eligibility based on exit codes (129-191 range for signal interruptions) and output patterns (HTTP/network-related keywords) - Added
retry_timefield to track retry attempts in the builds database model - Modified build completion flow to conditionally retry tasks before marking them as complete
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| orion-server/src/auto_retry.rs | New module implementing retry decision logic with exit code and output-based heuristics, including comprehensive tests |
| orion-server/src/api.rs | Integrates retry judger into message processing, adds retry loop for output analysis, and implements retry dispatch logic in BuildComplete handler |
| orion-server/src/scheduler.rs | Extends BuildInfo struct with auto_retry_judger and retry_time fields, initializes them during build creation |
| orion-server/src/model/builds.rs | Adds retry_time database column to track retry attempts |
| orion-server/src/main.rs | Registers auto_retry module |
| orion-server/src/lib.rs | Exports auto_retry module publicly |
| orion-server/Cargo.toml | Adds once_cell dependency for OnceCell usage |
| orion/src/api.rs | Documents that BuildResult's exit_code and can_auto_retry fields contain invalid data during immediate acknowledgment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fb3775dae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: TOP <89700178+topshihun@users.noreply.github.com>
Signed-off-by: Wangyan <topshihun@foxmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2eeb2ad92e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
topshihun
changed the title
topshihun
force-pushed
the
feat/task-auto-retry
branch
from
1312820 to
a8a3594
Compare
Signed-off-by: Wangyan <topshihun@foxmail.com>
topshihun
force-pushed
the
feat/task-auto-retry
branch
from
a8a3594 to
e14f1c7
Compare
Signed-off-by: Wangyan <topshihun@foxmail.com>
topshihun
force-pushed
the
feat/task-auto-retry
branch
from
e14f1c7 to
c75ef2a
Compare
* feat: auto retry time Signed-off-by: Wangyan <topshihun@foxmail.com> * Update orion-server/src/auto_retry.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: TOP <89700178+topshihun@users.noreply.github.com> * fix: clippy and other advices Signed-off-by: Wangyan <topshihun@foxmail.com> --------- Signed-off-by: Wangyan <topshihun@foxmail.com> Signed-off-by: TOP <89700178+topshihun@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
3 participants
No description provided.