-
Notifications
You must be signed in to change notification settings - Fork 461
Spigot 1.21.9-1.21.11, Paper 1.21.9-1.21.10 support #4239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3.0
Are you sure you want to change the base?
Conversation
|
Update: Someone tested it on paper and it doesn't work. It gives this error: Not sure what it means yet. Paper 1.21.9 isn't officially released yet so if it's on their end, maybe it will be resolved. |
|
Paper 1.21.9 build 41 is here https://papermc.io/downloads/paper . Paper is now a Hard Fork and new versions are developed along with the snapshots , that is why Paper gets releases on the same day as a Mojang release. 1.21.9 has been available for weeks for developers on the dev/1.21.9branch as was 1.21.8 Thanks Jacob for updating . |
|
I guess I was looking in the wrong places, then. I see now they have a button to show the 1.21.9 builds. Maybe someone that knows more about paper internals could chime in about what this means. Do I just need to target the paper api instead of the spigot api? My server is Spigot though, so I don't want to drop compatibility with that. It's not my decision to make to drop Spigot support either. My end goal was to switch my server over to fabric once the hard fork started forcing me to choose between spigot / paper plugins. I'd like to support both, but I know that will get harder over time. |
|
Just include the Paper API . Its enough just to import to main java and then in your Listening code . Scenerios could be as simple as a name change or KennyTV may have found a optimized way of inputing and exporting data . Mike has a lot of experience with Dynmap and Im sure he looks at the PR's often |
|
I asked on the PaperMC discord and got this response [8:39 PM] remapping from spigot mappings is not available on paper just yet, as we released the update before spigot was out So give it time, it should start working in paper in future versions. Migrating to paper-api, and using paperweight to get Mojang mappings would definitely make it far easier to update to new versions. And it would avoid problems like this, which will be unavoidable for a certain amount of days after every new MC update. I tried for a bit to handle it (for the 1.21.9 helper) but it's not something I want to spend too much time on. |
|
Now works on Paper again, if you download the latest paper jar from today or newer |
|
I updated this to 1.21.10, and renamed the directories to 1.21.10 (1.21.9 is now a dead version, quickly obsoleted by 1.21.10) |
|
Thanks! Unfortunately, this PR doesn't support the latest Purpur version |
It seems to work fine for me, do you have anything else running besides dynmap on Purpur? |
- MinecraftServer.registryAccess(): ba() -> bg() - Biome registry constant: Registries.aK -> Registries.aN - TileEntity.getBlockPos(): aA_() -> aD_() - World.registryAccess(): K_() -> L_() - NBT.Tag.asString(): p_() -> r_() Based on official Dynmap PR webbukkit#4239 implementation
|
@jbm11208 thanks for the message. I downloaded the latest Purpur build again, and it works. Idk what happened there |
…ointing to the wrong field (BiomeFog::e), it was using the right method (BiomeFog::e()) all along
|
I updated this PR to support 1.21.11 as well. Lots of obfuscation changes as usual, but nothing too different. This will probably be the last PR I send in for spigot, for a few reasons:
Basically, I just do this for my own use because it's easy. But the next update will be hard, and I don't have the time or need to do that. I'm also hoping that if I say now I'm not updating for 26.1, someone else will come along and figure out the right way to handle that update. I know enough to see that targetting obfuscated method names like this is unsustainable. I think targetting Spigot is unsustainable as well. I'd like to see the next update target Paper, drop support for legacy versions, and modernize the build infrastructure. But I'm not the one to do that, this isn't my personal project and who knows what will be merged. Edit: |
|
Oh no that's a bad news for community. You are the only person now updating this for spigot, while fabric versions are maintained by so many people. But anyway, thank you for your continuously updating for spigot❤️ |
To me it always seemed Spigot is a dead-end by comparison (no thanks to md-5), especially to Paper (not to mention the upcoming Folia), so I reckon Spigot will only spiral after Paper hard-forked away, and likewise I wouldn't think losing Spigot support will be a loss to anyone, except md-5 himself. |

All of the bukkit mappings are updated for 1.21.9/1/21.10. There were a lot of obfuscated method changes, as usual. No major api changes this time.
I did some initial testing and it loads / renders fine. Once the corresponding Fabric PR #4240 is merged, it will also render The Copper Age blocks.
I put a jar download on my fork for anyone that needs it before this PR is merged. (it's a combination of my and reusteur73's PRs so will render the new blocks).
Edit: Updated to 1.21.11. See my note on that down below