chore/update code format, replace declaration with expressions#846
chore/update code format, replace declaration with expressions#846potapovDim wants to merge 1 commit intowebdriverio:mainfrom
Conversation
|
Hi @potapovDim I am just curious about why did you do that ? What's wrong with function declaration? |
|
@udarrr nothing wrong with fn declaration, just to have a common code approach format across library i started to update it to expression format also expression could not be hosted in a way as declarations so better for reading, would be also good to add jsdoc comments and some lint format/prettier |
|
@potapovDim maybe it makes sense to introduce Prettier or EsLint to ensure that the next contributor doesn't switch this around again. I don't mind which code style we go with as long as we ensure we stick with it using these tools. |
|
@christian-bromann i can do that, can we merge this one and i will proceed with that next steps ? or do you want me to add this one as a part current PR ? i would also want to have pre - commit hook with lint and unit tests if it sounds suitable ? |
Let's add it to this PR if you don't mind |
Updated code format second iteration