chore(tooling): migrate from circleci to github actions for all workspaces #551
Conversation
## [1.27.6](webex/widgets@v1.27.5...v1.27.6) (2024-11-13) ### Bug Fixes * **WebexMeetings:** update member name from join prompt ([webex#240](webex#240)) ([a6c5298](webex@a6c5298))
## [1.27.7](webex/widgets@v1.27.6...v1.27.7) (2024-11-27) ### Bug Fixes * updated-to-latest-components ([webex#343](webex#343)) ([78c3e90](webex@78c3e90))
Co-authored-by: parv_gour <parv_gour@PAGOUR-M-D8B2>
## [1.27.8](webex/widgets@v1.27.7...v1.27.8) (2024-12-11) ### Bug Fixes * **release:** accessibility issues fixed on components repo. ([webex#346](webex#346)) ([6390d24](webex@6390d24))
# [1.28.0](webex/widgets@v1.27.8...v1.28.0) (2024-12-30) ### Features * **widgets:** enable password and name inputs during init ([webex#351](webex#351)) ([7f36b73](webex@7f36b73))
Co-authored-by: khushiG19 <500086354@stu.upes.ac.in>
## [1.28.1](webex/widgets@v1.28.0...v1.28.1) (2025-05-28) ### Bug Fixes * **accessibility:** fix wrong mic/camera instructions ([webex#450](webex#450)) ([ff88612](webex@ff88612))
## [1.28.2](webex/widgets@v1.28.1...v1.28.2) (2025-10-22) ### Bug Fixes * **meeting-widget:** add custom focus management and arrow key navigation ([webex#533](webex#533)) ([766a646](webex@766a646)) * **Meeting Widget:** stop screen readers focusing on visually hidden controls ([webex#532](webex#532)) ([d728896](webex@d728896))
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| publish-npm: | ||
| name: Publish - NPM | ||
| needs: [build, unit_tests] | ||
| needs: generate-package-matrix | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
The new deploy workflow removes the unit_tests job and now runs publish-npm after generate-package-matrix without executing any of the test commands that previously guarded releases (yarn run test:tooling, yarn run test:cc-widgets). This means a push to ccwidgets will publish packages without running tests, so a failing change will still be released. Please reintroduce the test job and make publish-npm depend on it to keep deployments validated.
Useful? React with 👍 / 👎.
| "demo:serve": "webpack serve ./demo/App.jsx --mode development", | ||
| "demo:build": "webpack ./demo/App.jsx --mode production", | ||
| "deploy:npm": "yarn npm publish", | ||
| "release": "semantic-release", |
There was a problem hiding this comment.
We can remove this line
Shreyas281299
left a comment
Shreyas281299
left a comment
There was a problem hiding this comment.
Mostly looks good
- Please remove the npm publish command from the root package.json
- Lets test this out once and ensure that only the packages with changes in published.
adhmenon
left a comment
adhmenon
left a comment
There was a problem hiding this comment.
Have we run e2e tests? Would like to just check if everything is working fine.
| git fetch origin documentation | ||
| git checkout origin/documentation -- docs/changelog/logs | ||
| - name: Update changelog |
There was a problem hiding this comment.
Did you try a commit with changelog?? I think you need to add the main.json and changelog/logs folder and file.
There was a problem hiding this comment.
I see the commit - bhabalan@bd8aa41#diff-ced9ab2f8a436cb420e898245b60acb585cae7c12ae13bf64cf6c9b126f306dd.
I think we need an optimization to what all needs to be updated, +188000, is a huge change that we are adding everytime a commit is made. Obvious should not be part of this but maybe we can have a ticket to address this
|
Did you try:
|
In the scripts we have to remove the sample-react-app and sample-wc-app |
|
And the UTs are failling |
Shreyas281299
added
the
run_e2e
9 participants
COMPLETES #CAI-6277
This pull request addresses
by making the following changes
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging