Fix Rack 3.x compatibility - Replace Rack.version with Rack.release
#282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick204nqh
force-pushed
the
patrick/fix-rack-version-method
branch
from
6ad3872 to
dcac416
Compare
patrick204nqh
changed the title
Rack::VERSIONRack.release
patrick204nqh
changed the title
Rack.releaseRack.version with Rack.release
Contributor
Author
|
@seancribbs @orien - saw you've been active on recent PRs, would love your thoughts on this when you get a chance. Let me know if you need anything from my end! |
orien
approved these changes
Nov 27, 2025
Contributor
There was a problem hiding this comment.
👍
Looks like Rack V1 has a release method also.
https://github.com/rack/rack/blob/1.6.13/lib/rack.rb#L21-L24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
webmachine-ruby 2.0.1 fails to load with Rack 3.x due to calling
Rack.versionwhich no longer exists.Error
Root Cause
Rack 3.x removed the
Rack.versionclass method. The VERSION constant is now a String instead of being accessible via a method.https://github.com/rack/rack/pull/1966/files#diff-75f019921d551ec3df0214212140eeda19369f014b93b77a9c92cfa64ec04c16
Solution
Replace
Rack.versionwithRack.releasewhich works in both Rack 2.x and 3.x.Hit this blocker during the Rack 3 upgrade. PR's ready when you have time to review.