Rubocop: resolve CI breaking issues #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
reviewed
Nov 27, 2025
lib/webmachine/media_type.rb
Outdated
| else | ||
| other.major == major && other.minor == Dispatcher::Route::MATCH_ALL_STR | ||
| end | ||
| [Dispatcher::Route::MATCH_ALL_STR, MATCHES_ALL, type].include?(other.type) || other.major == major && other.minor == Dispatcher::Route::MATCH_ALL_STR |
Contributor
There was a problem hiding this comment.
This line is a bit long, can you please add a new line after the ||?
Contributor
Author
There was a problem hiding this comment.
Updated. Thanks for your suggest
Add pstore gem for Ruby 4.0 compatibility Add logger and ostruct gems for Ruby 4.0 compatibility
patrick204nqh
force-pushed
the
patrick/fix-rubocop-lint
branch
from
d33ccb7 to
ff96766
Compare
patrick204nqh
commented
Nov 27, 2025
| gem 'pstore' | ||
| gem 'logger' | ||
| gem 'ostruct' | ||
| end |
Contributor
Author
There was a problem hiding this comment.
Added to Gemfile instead of gemspec since these are optional features (tracing) and dev concerns (testing), not core to webmachine - no need to bloat the dependency tree for all users.
orien
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Run RuboCop and fix lint offenses across the repo; no intentional behavior/API changes.
Changes
Reference
Test Results
4.0-dev(via asdf)