Skip to content

validate concat inputs and split splits#933

Open
philloooo wants to merge 1 commit into
webmachinelearning:mainfrom
philloooo:main
Open

validate concat inputs and split splits#933
philloooo wants to merge 1 commit into
webmachinelearning:mainfrom
philloooo:main

Conversation

@philloooo
Copy link
Copy Markdown
Contributor

@philloooo philloooo commented May 6, 2026

Fixes #931
Add validation that checks the concat inputs size is not greater than 8192 and split splits size is not greater than 8192.

@fdwr @huningxin


Preview | Diff

Copy link
Copy Markdown
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one thought.

Comment thread index.bs Outdated
Copy link
Copy Markdown
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread index.bs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define an upper bound on number of concat inputs and split outputs

2 participants