Skip to content

Conversation

@bjohansebas
Copy link
Member

Summary

Compression should work fine in HTTP/2, at least when using the compatibility mode that is already used when creating the server here, see expressjs/compression#129 and https://github.com/expressjs/compression/pull/170.”](https://github.com/expressjs/compression/pull/170

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.56%. Comparing base (1a30c21) to head (456fcca).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #5638   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          11       11           
  Lines        1947     1947           
  Branches      723      724    +1     
=======================================
  Hits         1627     1627           
  Misses        287      287           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case for connect here just to prove it really works

@bjohansebas
Copy link
Member Author

sure i will do

@bjohansebas
Copy link
Member Author

But compression is enabled by default, so is this still necessary?

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait merged commit 18704b6 into next Jan 29, 2026
94 of 151 checks passed
@alexander-akait alexander-akait deleted the compression-http2 branch January 29, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants