Fix WebSocketClient onMessage event naming #5640
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves code clarity in
WebSocketClientby renaming theonmessagecallback parameter fromerrtoevent.The previous name was misleading, as the parameter represents a
MessageEvent, not an error. This change aligns the variable name with the actual WebSocket API and improves readability and maintainability without altering runtime behavior.What kind of change does this PR introduce?
Refactor (non-functional, clarity improvement)
Did you add tests for your changes?
No. This change is a naming refactor only and does not affect logic or behavior.
Does this PR introduce a breaking change?
No. This change is purely internal and does not impact the public API or runtime behavior.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No documentation changes are required.