This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Fix property visibility in Router class#20
Open
lsilvio wants to merge 1 commit intoweglot:developfrom
lsilvio:fix-property-visibility-router
Open
Fix property visibility in Router class#20lsilvio wants to merge 1 commit intoweglot:developfrom lsilvio:fix-property-visibility-router
lsilvio wants to merge 1 commit intoweglot:developfrom
lsilvio:fix-property-visibility-router
Conversation
According to symfony 4.2.8 version, the property defaultLocale shoud be protected or weaker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to symfony 4.2.8 version, the property defaultLocale shoud be protected or weaker
=> symfony/symfony@203a87a
What this PR does / why we need it:
Fix a visibility issue on defaultLocale property in Router class. Allow to run bin/console cache:clear without error.
Which issue(s) this PR fixes: