fix: prevent sub-pixel values for Arena padding - #13
Open
larrifax wants to merge 1 commit into
Open
Conversation
|
@larrifax is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts SVG/foreignObject padding calculation to avoid fractional/zero padding values.
Changes:
- Updates
paddingto be at least 1 and rounds half-cell padding up to the next integer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const start = Math.ceil(edgeSize / 2 - arenaSize / 2) | ||
| const size = arenaSize + (arenaSize % 2) | ||
| const padding = cellSize / 2 | ||
| const padding = Math.max(Math.ceil(cellSize / 2), 1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm experiencing Arena
paddingvalues of e.g.0.5px, which causes rendering bugs ultimately causing the arena image to be rendered "off-center".This PR does the following:
paddingis at least1pxpaddingvalues up to the nearest integer (could've rounded down, but noticed you usedMath.ceilelsewhere)