Open
Conversation
| } | ||
|
|
||
| "have implicit `not` method" in new SpecExamples { | ||
| // val filtered = sampleList.filter(Predicate1.not.not(Modulo(2, 0))) |
Collaborator
Author
There was a problem hiding this comment.
Commented out line worked with old API. Predicate.not.not looked weird so I simply changed it to a method. Maybe I was missing something - how it was intended to be used?
Owner
|
This reduces a lot of boilerplate. You intend to have the macro essentially generate all the variants, a la boilerplate.scala? 👍 |
Collaborator
Author
|
Yeah, I want to have macro generating all variants of |
Owner
|
I should add, that if we ever want to get to that 2.10 cross build (yes, I know, I've been terrible about it) while also introducing macros, we should consider adding macro-compat from Miles Sabin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created branch
macrosto which I will be creating next PR's related to reimplementation of Predicates using macros. This PR is mostly for code sharing and discussion - it just reimplementsPredicate1using macro annotation.@wheaties please take a look, I am really interested what you think about such approach. I slightly changed an API in 3 places - will add a github comments in those lines in a minute.