Add requested template variables#536
Merged
Merged
Conversation
Freso
approved these changes
May 15, 2021
Member
Freso
left a comment
Freso
left a comment
There was a problem hiding this comment.
At a glance, having only read through the PR and not tested it, it looks good. 👍
JoeLametta
force-pushed
the
misc-changes-template
branch
2 times, most recently
from
9642e3a to
0deb9fb
Compare
Collaborator
Author
|
Sorry, made a bit of a mess: two commits got accidentally fixed up in a previous one. I've force pushed with the commits split and updated the description of the pull request. Because of the mistake, these variables were not included in the initial description:
|
JoeLametta
force-pushed
the
misc-changes-template
branch
2 times, most recently
from
5238d8d to
f5072c8
Compare
Already included but were not allowed. Improved documentation. Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
- Trasparent change: now it makes more sense. - Updated tests to reflect 'title', 'releaseTitle' meaning swap. - Improved documentation. Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
- %M: total number of discs in the chosen release - %N: number of current disc Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Co-authored-by: Máximo Castañeda <antiswen@yahoo.es> Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
JoeLametta
force-pushed
the
misc-changes-template
branch
from
f5072c8 to
9d67144
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends the supported template variables. Additions:
%B: release barcode (already included but is now allowed)%C: release catalog number (already included but is now allowed)%c: release disambiguation comment%D: disc title without disambiguation%I: MusicBrainz Disc ID%M: total number of discs in the chosen release%N: number of current disc%T: medium titleWhen the relative metadata is available, whipper now adds the
TRACKTOTAL,DISCTOTALandDISCNUMBERmetadata tags to the audio tracks.I've also taken the inspiration from pull request #476.
I haven't tested the changes so I can't guarantee that the added features will work as expected.
Resolves #401, resolves #440, resolves #448.