Open
Conversation
Compute the length of the longest prefix match.
msimerson
reviewed
Apr 9, 2024
|
|
||
| IPv4.prototype.commonPrefixLength = function (other) { | ||
| if (other.kind() !== 'ipv4') { | ||
| throw new Error('ipaddr: cannot match ipv6 address with non-ipv6 one'); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new Error('ipaddr: cannot match ipv6 address with non-ipv6 one'); | |
| throw new Error('ipaddr: cannot match ipv4 address with non-ipv4 one'); |
whitequark
reviewed
Apr 9, 2024
Owner
whitequark
left a comment
whitequark
left a comment
There was a problem hiding this comment.
What's the use case? I'm unconvinced this is a functionality ipaddr.js should be providing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute the length of the longest prefix match.