Skip to content

[Cocoapods] Remove module map from compiled classes - #9

Open
fjtrujy wants to merge 2 commits into
wickwirew:masterfrom
fjtrujy:cocoapods
Open

[Cocoapods] Remove module map from compiled classes#9
fjtrujy wants to merge 2 commits into
wickwirew:masterfrom
fjtrujy:cocoapods

Conversation

@fjtrujy

@fjtrujy fjtrujy commented Aug 8, 2019

Copy link
Copy Markdown

Hello,
In order to solve this warning, I have been forced to create a private and dummy class because otherwise it is not recognized as a module when you try to use it as a dependency.

Thanks

@fjtrujy

fjtrujy commented Aug 8, 2019

Copy link
Copy Markdown
Author

Remember to push version to Cocoapod, I have bumped the version already xD

@fjtrujy
fjtrujy force-pushed the cocoapods branch 3 times, most recently from 1440ab2 to d8ebed3 Compare August 8, 2019 15:04
@wickwirew

Copy link
Copy Markdown
Owner

Thanks for taking a look at this! Got a chance to try it out. Cocoapods works now, but it looks like the SPM build is broken. Getting this error:

umbrella header 'CRuntime-umbrella.h' not found umbrella header "CRuntime-umbrella.h"

@fjtrujy

fjtrujy commented Aug 10, 2019

Copy link
Copy Markdown
Author

Sorry, I just tried cocoapods, I will give a try this week to SPM
Thanks!

@arturdev

arturdev commented Jan 8, 2020

Copy link
Copy Markdown

I think SPM compatibility is not big deal. Having 0 warning is more crucial than supporting multiple package managers...

@fjtrujy

fjtrujy commented Jan 9, 2020

Copy link
Copy Markdown
Author

Sorry,
I couldn't dedicate time to try in SPM yet, but if you are happy with this you can merge it if you want

@arturdev

Copy link
Copy Markdown

@wickwirew ?

@wickwirew

Copy link
Copy Markdown
Owner

Took a look at it tonight and made some progress. I want to remove CRuntime as a dependency and include the header file in Runtime package. Hopefully this should add Carthage support as well. Ill try to finish it up soon but I have a busy few weeks coming up. If someone fixes before I do I'd be happy to merge is as long as it doesn't break anything.

@arturdev

Copy link
Copy Markdown

@wickwirew do you have any progress on this?

@wickwirew

wickwirew commented Feb 26, 2020

Copy link
Copy Markdown
Owner

@arturdev Yea. Everything seems to work. CocoaPods has no warnings, and SPM still functions as expected. Here the branch if you want to try it out: no-cruntime

@arturdev

Copy link
Copy Markdown

@wickwirew that's awesome!
Will it be merged to master soon?

@arturdev

arturdev commented Mar 6, 2020

Copy link
Copy Markdown

@wickwirew ?

@wickwirew

Copy link
Copy Markdown
Owner

@arturdev Its merged. Working on a few bug fixes then will do a release

@arturdev

Copy link
Copy Markdown

@wickwirew Awesome!! Looking forward to the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants