feat: add multiple file browser selection#1162
Open
maartenbreddels wants to merge 1 commit into
Open
Conversation
9e4f205 to
f20f4c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileBrowseraround a reusable internal base while preserving single-selection behavior and string-directory compatibility.FileBrowserMultipleforPath-only multiple selection with optimistic row highlighting and selected-row ripple handling.Usage snippets
Single file selection keeps the existing
FileBrowserAPI:Multiple file selection uses
FileBrowserMultipleandPathvalues:Callback style also receives
Pathvalues:Demo
report.csvandnotes.txt, togglingreport.csv, and clearing the remaining selection.filebrowser-multiple-pr-demo.mp4
Tests
uv run pytest tests/unit/file_browser_test.py::test_file_browser_callback_can_select tests/unit/file_browser_test.py::test_file_browser_relative_path tests/unit/file_browser_test.py::test_file_browser_programmatic_select tests/unit/file_browser_test.py::test_file_browser_multiple_callback_select tests/unit/file_browser_test.py::test_file_browser_multiple_programmatic_select tests/unit/file_browser_test.py::test_file_browser_multiple_open_and_navigate_clear_selection tests/unit/file_browser_test.py::test_file_browser_multiple_does_not_select_parent tests/unit/file_browser_test.py::test_file_browser_multiple_requires_path_directory tests/unit/file_browser_test.py::test_file_browser_base_supports_generic_source -q