remove composer.lock (see issue #116) & fix some typos#117
remove composer.lock (see issue #116) & fix some typos#117widmogrod merged 1 commit intowidmogrod:masterfrom
Conversation
WalkthroughAdded Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I am not sure how CI behaves because I am not familiar with the config here, if something breaks, you need to give me a hint or maybe try to fix it yourself. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.gitignore (1)
5-5: composer.lock ignore: good for libraries; scope it to repo rootIf this repo is intended as a library (it appears so), ignoring composer.lock is appropriate. To avoid ignoring lockfiles in nested example folders, prefer anchoring to the root.
Apply:
-composer.lock +/composer.lockREADME.md (2)
27-27: List item punctuation LGTM; fix MD007 list indentationThe “a.k.a.” punctuation looks good. Markdownlint flags this bullet’s extra leading space. Align top-level bullets with column 0 for consistency.
Apply:
- * `Num` - * `Sum` - * `Product` - * `Stringg` - * `Listt` (a.k.a. List Monad, since `list` is a protected keyword in PHP) +* `Num` +* `Sum` +* `Product` +* `Stringg` +* `Listt` (a.k.a. List Monad, since `list` is a protected keyword in PHP)
317-319: Tighten phrasing: “syntactic sugar” + commasMinor grammar/style polish.
Apply:
-In Haskell is just a "syntax sugar" and in many ways is not needed, -but in PHP control flow of monads can be hard to track. +In Haskell it's just syntactic sugar and, in many ways, isn't needed, +but in PHP, the control flow of monads can be hard to track.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.gitignore(1 hunks)README.md(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
27-27: Unordered list indentation
Expected: 0; Actual: 1
(MD007, ul-indent)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
243-245: Use asterisks for list style and tighten grammar.Keeps list markers consistent with the rest of the README (and silences MD004). Also fixes small grammar nits.
- - how and from where get user discounts - - how and where save products in basket - - and more ... + * how and where to get user discounts + * how and where to save products in the basket + * and more...
367-375: Replace bare URLs with descriptive links.Improves readability and resolves MD034.
-* http://drboolean.gitbooks.io/mostly-adequate-guide -* https://github.com/fantasyland/fantasy-land -* http://adit.io/posts/2013-04-17-functors,_applicatives,_and_monads_in_pictures.html -* http://learnyouahaskell.com/functors-applicative-functors-and-monoids -* http://learnyouahaskell.com/starting-out#im-a-list-comprehension -* http://robotlolita.me/2013/12/08/a-monad-in-practicality-first-class-failures.html -* http://robotlolita.me/2014/03/20/a-monad-in-practicality-controlling-time.html -* https://github.com/folktale/data.either -* https://github.com/widmogrod/php-algorithm-w +* [Mostly Adequate Guide](http://drboolean.gitbooks.io/mostly-adequate-guide) +* [Fantasy Land](https://github.com/fantasyland/fantasy-land) +* [Functors, Applicatives, and Monads in Pictures](http://adit.io/posts/2013-04-17-functors,_applicatives,_and_monads_in_pictures.html) +* [LYAH: Functors, Applicative Functors, and Monoids](http://learnyouahaskell.com/functors-applicative-functors-and-monoids) +* [LYAH: List Comprehension](http://learnyouahaskell.com/starting-out#im-a-list-comprehension) +* [A Monad in Practicality: First-Class Failures](http://robotlolita.me/2013/12/08/a-monad-in-practicality-first-class-failures.html) +* [A Monad in Practicality: Controlling Time](http://robotlolita.me/2014/03/20/a-monad-in-practicality-controlling-time.html) +* [folktale/data.either](https://github.com/folktale/data.either) +* [widmogrod/php-algorithm-w](https://github.com/widmogrod/php-algorithm-w)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.gitignore(1 hunks)README.md(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .gitignore
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
243-243: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
244-244: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
245-245: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
367-367: Bare URL used
(MD034, no-bare-urls)
368-368: Bare URL used
(MD034, no-bare-urls)
369-369: Bare URL used
(MD034, no-bare-urls)
370-370: Bare URL used
(MD034, no-bare-urls)
371-371: Bare URL used
(MD034, no-bare-urls)
372-372: Bare URL used
(MD034, no-bare-urls)
373-373: Bare URL used
(MD034, no-bare-urls)
374-374: Bare URL used
(MD034, no-bare-urls)
375-375: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (3)
README.md (3)
12-18: LGTM on the Monad list formatting.Bullet list reads clearly and matches the rest of the doc’s style.
23-27: LGTM on “a.k.a.” punctuation fix.“The Listt (a.k.a. List Monad …)” reads correctly now.
317-318: LGTM on the “do notation” wording tweak.Sentence reads better; no further changes needed.
|
LGTM. Thank you for the contribution! |
|
@widmogrod Could you please create a new patch level release/tag so this change is covered in the tagged versions? |
|
tag 7.0.1 release |
🏆 Awesome. |
2 participants
Changelog
This could lead to a new patch level release (tag).
Summary by CodeRabbit
Documentation
Chores