Conversation
Owner
|
Hi, ty for this. Any chance you allow maintainer for modification? Its easier for me to do modif before merging. |
wiiznokes
force-pushed
the
feat/list-view
branch
from
0fabf85 to
8f89d49
Compare
Owner
|
Hum, i must have not setup correctly something locally if i can force push your branch (from github ui). You can ignore the last message, since you probably already checked the option |
Contributor
Author
|
Np, yeah it's enabled |
wiiznokes
force-pushed
the
feat/list-view
branch
from
8f89d49 to
3b02509
Compare
wiiznokes
requested changes
Dec 9, 2025
Owner
wiiznokes
left a comment
wiiznokes
left a comment
There was a problem hiding this comment.
Looks mostly good.
Also, can you add the rememberNestedScrollConnection stuff in listview ?
And there is also a bug where the position of the dropdown when we long click an item in the listview is not on the click position.
app/src/main/java/io/github/wiiznokes/gitnote/ui/screen/app/grid/GridScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/github/wiiznokes/gitnote/ui/screen/app/grid/GridScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/github/wiiznokes/gitnote/ui/screen/app/grid/GridScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/github/wiiznokes/gitnote/ui/screen/app/grid/ListView.kt
Show resolved
Hide resolved
app/src/main/java/io/github/wiiznokes/gitnote/ui/screen/app/grid/TopGrid.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/github/wiiznokes/gitnote/ui/screen/app/grid/TopGrid.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
PR feedback should be resolved. Please have another look. |
Owner
|
see #154. I haven't succed to push to your branch unfortunately :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds list view with toggle in the header. Closes #106.