This repository was archived by the owner on Aug 9, 2024. It is now read-only.
Conversation
halfak
commented
Aug 22, 2019
halfak
force-pushed
the
session_orientation
branch
2 times, most recently
from
90cef5c to
41c409e
Compare
accraze
suggested changes
Sep 9, 2019
Member
accraze
left a comment
accraze
left a comment
There was a problem hiding this comment.
There are a couple of failing tests due to some refactoring that need fixing, but overall LGTM!
https://travis-ci.org/wikimedia/revscoring/builds/582717322#L794
halfak
force-pushed
the
session_orientation
branch
5 times, most recently
from
c6cc8d8 to
66b5e35
Compare
accraze
reviewed
Oct 8, 2019
Member
accraze
left a comment
accraze
left a comment
There was a problem hiding this comment.
Looks great so far, everything seems well documented and tested.
* Adds 'list_of' meta-datasource * Adds documentation
halfak
force-pushed
the
session_orientation
branch
from
da8d20b to
04bb9df
Compare
accraze
reviewed
Mar 20, 2020
Member
accraze
left a comment
accraze
left a comment
There was a problem hiding this comment.
I like the @DependentSet.meta_dependent decorator, although not sure if it will be a ton of work to find all functions that it should be added to. If you aren't worried about that then I would say go ahead with applying this to the language based features.
Also it looks like there is a problem with docs checker on Travis:
revscoring/features/bytes/session_oriented.py:docstring of
revscoring.features.bytes.Session.revisions:1:py:class reference target not found:
revscoring.datasources.meta.expanders.list_of`(:class:`~revscoring.features.bytes.Revision
| if not hasattr(method, "meta_dependent"): | ||
| pass | ||
| else: | ||
| list_of_meta_method = meta_list_of_ify( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a nice structure for session orientation using a helper function called "list_of_tree" that takes a DependencySet and iterates through it converting all children and maintaining the structure of the tree. A cache is used to keep track of what dependencies have already been converted so that they can be re-used.