chore: Simplify taplo install in CI#2004
Merged
Merged
Conversation
lapla-cogito
force-pushed
the
taplo_installaction
branch
from
da4b3ae to
84c5c03
Compare
lapla-cogito
commented
May 31, 2026
| - name: Install Taplo (AArch64) | ||
| if: ${{ runner.arch == 'ARM64' }} | ||
| run: curl -fsSL https://github.com/tamasfe/taplo/releases/latest/download/taplo-linux-aarch64.gz | gzip -d - | install -m 755 /dev/stdin /usr/local/bin/taplo | ||
| - run: taplo format --check --diff |
Member
Author
There was a problem hiding this comment.
TBH I don't understand the purpose behind this job that only displays diffs (which is why I removed it). Seeing other tidy tests like clang-format, this job is likely unnecessary.
| @@ -1,5 +1 @@ | |||
| exclude = [ | |||
| ".cargo-home/**", | |||
| "external_test_suites/mold/third-party/blake3/Cargo.toml", | |||
Member
Author
There was a problem hiding this comment.
Considering future updates to external tests, all files under external_test_suites should be included as ignored-files.
marxin
approved these changes
May 31, 2026
Collaborator
marxin
left a comment
marxin
left a comment
There was a problem hiding this comment.
Thank you for the clean-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.