Skip to content

Conversation

@rbroemeling
Copy link
Contributor

String thresholds that were being passed in were being uppercased, which guaranteed that they could never match a non-uppercased value being returned from Redis.

…anteed that you could never match a non-uppercased value.
@willixix
Copy link
Owner

I'll take this as an open issue for the library. Pull request is no go here as I simply copy library code into plugin when I get new version ready.

@rbroemeling
Copy link
Contributor Author

OK. Is there a different file that I should issue a PR to?

This was a critical problem for me -- it makes checking the value of the Redis "role" completely impossible, for instance. The value returned from Redis is lower-case, and this bug makes it impossible to match a lower-case string.

@willixix
Copy link
Owner

Yes, I understand its core issue for you and its something I overlooked when I upgraded my threshold code into library with new long-option syntax. Use your modified version. This will get fixed in the next release, there are a lot more work going into library so I prefer no submission there until its more stable and ready for use by others. After submissions to Naglio.pm on dev branch will be accepted.

The other staff forr check_redis that you submitted will get fixed too, some of my bad spellings I already fixed on my side and I will see how I can merge with what you submitted since I'm working on everything in dev branch.

@willixix
Copy link
Owner

Please test latest check_redis.pl and Naglio.pm in dev branch. There are a lot of changes to library code (its been updated to support multiple WARN and CRIT keywords on threshold option), among that is fix so that both upper-case and lowercase values when specifying threshold are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants