Skip to content

fix: use pkg-config to source liquid-dsp dependency#3

Closed
EthanJStark wants to merge 2 commits intowindytan:masterfrom
EthanJStark:liquid-dsp-bug
Closed

fix: use pkg-config to source liquid-dsp dependency#3
EthanJStark wants to merge 2 commits intowindytan:masterfrom
EthanJStark:liquid-dsp-bug

Conversation

@EthanJStark
Copy link

Hi! Thank you for sharing this project, works great!

I was having an issue since meson.build was looking for Homebrew libraries in specific places (mine are in /usr/local/Cellar/)

This should address that issue.

@windytan
Copy link
Owner

Thanks for the help! It doesn't seem to work just yet on the CI pipeline; I wonder what the issue is? Here's the snippet from the github runner

Determining dependency 'liquid' with pkg-config executable '/opt/homebrew/bin/pkg-config'
env[PKG_CONFIG_PATH]: 
env[PKG_CONFIG]: /opt/homebrew/bin/pkg-config
-----------
Called: `/opt/homebrew/bin/pkg-config --modversion liquid` -> 1
stderr:
Package liquid was not found in the pkg-config search path.
Perhaps you should add the directory containing `liquid.pc'
to the PKG_CONFIG_PATH environment variable
Package 'liquid' not found

@EthanJStark
Copy link
Author

Hi! Thanks for the quick reply.

Just pushed a fix for build.yml d7d8f04

Looks like you need to approve to have the Github workflow rerun

@windytan
Copy link
Owner

windytan commented Feb 1, 2025

I changed the runner approval setting to the most lenient one now (established users can run).

On my Homebrew macOS I am getting this same error. There doesn't seem to be a liquid.pc file in the system, even though liquid is installed using brew. Seems that liquid doesn't come with one out-of-the-box; I found an open PR about it though.

@windytan
Copy link
Owner

Ethan, I had the same problem with another project. I've copied my solution here in PR #4 . Can you test that it works for you when you have time.

@windytan
Copy link
Owner

I believe it can be closed

@windytan windytan closed this Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants