A Fediverse address on this vutuv becomes a plain vutuv follow (v7.206.0) - #1253
Merged
Conversation
…6.0)
Members could paste another member's (or their own) fediverse address
into the follow box and were refused with a dead end, or, through the
profile's "follow from your own server" dialog, even made vutuv
WebFinger itself. Now Fediverse.follow_remote/2 diverts any address
whose host is this installation before the fediverse gates: a
member-naming address creates the ordinary Vutuv.Social follow
({:ok, {:local_follow, member}}), the member's own address is refused
as :own_account (nobody follows themselves, matching the changeset
guard on plain follows), and an unknown handle keeps the
:local_account refusal with a search hand-off.
The same short-circuit sits in RemoteFollowController (signed-in
members get the local follow of the profile owner, signed-out visitors
an explanation, never a WebFinger of ourselves, the issue-1211 shape),
and the account lookup page now navigates a member-naming address to
that member's profile instead of refusing.
The non-federating gate deliberately does not apply to the local
branch: a vutuv follow needs no actor key. German translations written
by hand (one fuzzy-filled msgstr corrected). New shared test helper
Vutuv.EndpointHostHelper dresses the test endpoint in a dotted
hostname. Also removes an unused require Logger in the account
lifecycle test that warned on every run.
An AI agent wrote this text in my name, unreviewed by me. The work
behind it is mine; I only delegated the writing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Members can no longer subscribe to another member's (or their own) Fediverse account on the same installation.
Fediverse.follow_remote/2now diverts any address whose host is this installation before the Fediverse gates:{:ok, {:local_follow, member}}), with a confirmation flash on the following page:own_account(nobody follows themselves; plain follows were already guarded by the changeset):local_accountrefusal, now with a search hand-off onlyThe profile's "follow from your own server" dialog short-circuits local addresses too (signed-in members get the local follow of the profile owner, signed-out visitors an explanation) instead of WebFingering ourselves (the #1211 shape), and the account lookup page navigates a member-naming address to that member's profile.
Also: German translations written by hand (one fuzzy msgstr corrected), shared
Vutuv.EndpointHostHelpertest helper, removed an unusedrequire Loggerwarning in the account lifecycle test.Hot deploy (no migrations, no config/dependency/supervision changes). Version v7.206.0.
An AI agent wrote this text in my name, unreviewed by me. The work behind it is mine; I only delegated the writing.