The two experiment-counter test modules run sync, ending a deadlock flake (v7.206.3) - #1257
Merged
Conversation
…lake Both VutuvWeb.LandingExperimentTest and Vutuv.ExperimentsTest upsert the same experiment_stats rows - the fixed production variants "stube"/"knapp" on today's Berlin day - and both ran async: true. Two async modules incrementing the same unique-key rows in opposite orders deadlock (40P01, the exact pattern the test guidelines codify); the lost increment then failed the counting assertions. It just blocked a routine push at the pre-push gate with two red tests unrelated to the change being pushed. The variant names are production data, not test literals, so they cannot be uniquified per module; per the guideline, every module touching the shared rows goes async: false, with the reason in the moduledoc so nobody flips it back for speed. An AI agent wrote this text in my name, unreviewed by me. The work behind it is mine; I only delegated the writing. Claude-Session: https://claude.ai/code/session_014ksBm1P9qsazixAHFeHwMc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VutuvWeb.LandingExperimentTestandVutuv.ExperimentsTestboth upsert the sameexperiment_statsrows (the fixed production variantsstube/knappon today's Berlin day) and both ranasync: true. Two async modules incrementing the same unique-key rows in opposite orders deadlock (40P01 — the exact pattern the test guidelines codify); the counter increment that loses the deadlock is dropped and the counting assertions fail. This just turned a routine pre-push gate red with two failures unrelated to the change being pushed.The variant names are production data, not test literals, so they cannot be uniquified per module. Per the guideline, every module touching the shared rows goes
async: false, with the reason in the moduledoc so nobody flips it back for speed.mix precommitgreen (6,240 tests).An AI agent wrote this text in my name, unreviewed by me. The work behind it is mine; I only delegated the writing.
https://claude.ai/code/session_014ksBm1P9qsazixAHFeHwMc