The admin dashboard links to the screenshot blocklist, so it can be found (v7.208.1) - #1261
Merged
Conversation
…ound (v7.208.1)
The blocklist editor shipped as a third tab of /admin/screenshots, which is
only discoverable if you already know it is there: nothing on /admin pointed at
it, and the neighbouring card's text is about the capture queue.
It gets a card of its own rather than a line in that one, for two reasons. The
whole admin card is a single link, so a second destination needs a second card
at all. And a site whose preview is nothing but a cookie banner is a task an
admin arrives with ("why does this link look broken?"), not a setting they go
looking for behind a tab. The card carries the entry count, so the dashboard
also says at a glance whether anything is on the list.
A test now asserts /admin renders the link, in English and German, since the
missing link is exactly the kind of gap a green test suite does not notice.
An AI agent wrote this text in my name, unreviewed by me. The work behind it
is mine; I only delegated the writing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR The blocklist editor shipped in #1260 as a third tab of
/admin/screenshots, with nothing on/adminpointing at it./adminnow has a "Screenshot blocklist" card linking straight to it.Where:
templates/admin/admin/index.html.heex+Admin.AdminController.indexNow: the tab is only reachable if you already know it exists; the neighbouring card's text is about the capture queue.
Want: a dashboard card of its own →
/admin/screenshots?tab=blocklist.Its own card rather than a line in the existing one, for two reasons: the whole admin card is a single
<a>, so a second destination needs a second card at all; and a site whose preview is nothing but a cookie banner is a task an admin arrives with ("why does this link look broken?"), not a setting they go hunting for behind a tab. The card shows the entry count, so the dashboard also says at a glance whether anything is on the list.A test asserts
/adminrenders the link in English and German — a missing link is exactly the gap a green suite does not notice.Deploy: hot. Version 7.208.1.
mix precommitgreen locally (6291 tests).An AI agent wrote this text in my name, unreviewed by me. The work behind it is mine; I only delegated the writing.