WPB-23638: Provide jitter and connection information from web#139
Open
sifa-wire wants to merge 1 commit intorelease-10.3from
Open
WPB-23638: Provide jitter and connection information from web#139sifa-wire wants to merge 1 commit intorelease-10.3from
sifa-wire wants to merge 1 commit intorelease-10.3from
Conversation
|
EnricoSchw
requested changes
Mar 2, 2026
Contributor
EnricoSchw
left a comment
EnricoSchw
left a comment
There was a problem hiding this comment.
I consider it more important to measure the pkg loss and jitter on the outgoing stream than on the incoming stream.
We don't always send videos, so measuring the audio stream isn't very helpful in any case, however, if problems arise, we tend to notice them more during transmission sending than receiving.
| struct iflow; | ||
| struct avs_vidframe; | ||
|
|
||
| enum connection_type { |
Contributor
There was a problem hiding this comment.
I am in favor of splitting this enum into two different enums.
enum connection_type {
CONNECTION_TYPE_UNKNOWN = 0,
CONNECTION_TYPE_HOST = 1,
CONNECTION_TYPE_ SRFLX = 2,
CONNECTION_TYPE_ PRFLX = 3,
CONNECTION_TYPE_RELAY = 4,
}
enum connection_protocol {
CONNECTION_PROTOCOL_UNKNOWN = 0,
CONNECTION_PROTOCOL_UDP = 1,
CONNECTION_PROTOCOL_ TCP= 2,
}
| } | ||
| else if (stat.type === 'candidate-pair') { | ||
| rtt = stat.currentRoundTripTime * 1000; | ||
| if (stat.nominated === true && stat.state === "succeeded") { |
Contributor
There was a problem hiding this comment.
we should only measure on the selected pair
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide jitter and connection information from web side
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.