Skip to content

Conversation

@jullianm
Copy link
Contributor

@jullianm jullianm commented Dec 23, 2025

TaskWPB-21647 [iOS] Search files in Conversation

Issue

This PR introduces a new action on the conversation search screen: the ability to search for files on a wire cells enabled conv. User will be redirected to the Files view that lists all the files for the conv with the ability to search for a specific file.

Simulator.Screen.Recording.-.Snapshots.-.2025-12-23.at.14.17.01.mov

Testing

  • on a wire cells enabled conv, tap on the on the conv name, then "Search", it opens up the (legacy) search screen with a new cell "Search files" which, on tap, it opens modally the Files list for the conv + a search bar.
  • on that cell, clicking on the information icon opens up an alert, and on Search files action tapped, it opens up the view like mentioned above.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm requested review from a team and johnxnguyen and removed request for a team December 23, 2025 13:28
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

Test Results

242 tests   240 ✅  43s ⏱️
 52 suites    0 💤
  1 files      2 ❌

For more details on these failures, see this check.

Results for commit b3e9655.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 23, 2025

⚠️ Tests

⚠️ Warnings

🧪 2 Tests failed

testFilesView_LoadingState() from WireMessagingTests.FilesViewTests (Datadog)
FilesViewTests.swift:331: XCTAssertNil failed: "Snapshot "dark" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/WireMessaging/Tests/WireMessagingTests/Resources/ReferenceImages/FilesViewTests/testFilesView_LoadingState.dark.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/WireMessaging/Tests/WireMessagingTests/Resources/SnapshotResults/FilesViewTests/testFilesView_LoadingState.dark.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...
testFilesView_NoDataState() from WireMessagingTests.FilesViewTests (Datadog)
FilesViewTests.swift:343: XCTAssertNil failed: "Snapshot "dark" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/WireMessaging/Tests/WireMessagingTests/Resources/ReferenceImages/FilesViewTests/testFilesView_NoDataState.dark.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/WireMessaging/Tests/WireMessagingTests/Resources/SnapshotResults/FilesViewTests/testFilesView_NoDataState.dark.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b3e9655 | Docs | Was this helpful? Give us feedback!

@jullianm jullianm requested review from WilhelmOks and samwyndham and removed request for KaterinaWire and johnxnguyen January 5, 2026 10:01
@OlivellaO OlivellaO self-requested a review January 7, 2026 10:37
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work fighting the legacy!

import WireFoundation

final class CollectionSearchFilesCell: CollectionCell {
private var containerView = UIView()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nip pick: this can be a let right?


case CollectionsSectionSet.searchFiles:
desiredWidth = contentView.collectionView.bounds.size.width - horizontalInset(in: section)
if !CollectionsView.useAutolayout {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: It's interesting how some legacy feature toggle comes back to haunt us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants