-
Notifications
You must be signed in to change notification settings - Fork 24
feat: search files in conversation - WPB-21647 #4051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Test Results242 tests 240 ✅ 43s ⏱️ For more details on these failures, see this check. Results for commit b3e9655. ♻️ This comment has been updated with latest results. |
|
samwyndham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work fighting the legacy!
| import WireFoundation | ||
|
|
||
| final class CollectionSearchFilesCell: CollectionCell { | ||
| private var containerView = UIView() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nip pick: this can be a let right?
|
|
||
| case CollectionsSectionSet.searchFiles: | ||
| desiredWidth = contentView.collectionView.bounds.size.width - horizontalInset(in: section) | ||
| if !CollectionsView.useAutolayout { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: It's interesting how some legacy feature toggle comes back to haunt us
Issue
This PR introduces a new action on the conversation search screen: the ability to search for files on a wire cells enabled conv. User will be redirected to the Files view that lists all the files for the conv with the ability to search for a specific file.
Simulator.Screen.Recording.-.Snapshots.-.2025-12-23.at.14.17.01.mov
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: