[WPB-23644] Fix golden JSON fixtures for TeamContact (based on WPB-23644-fix-subsystems-dep-graph)#5082
Draft
[WPB-23644] Fix golden JSON fixtures for TeamContact (based on WPB-23644-fix-subsystems-dep-graph)#5082
TeamContact (based on WPB-23644-fix-subsystems-dep-graph)#5082Conversation
Contributor
…factor inferUserType Co-authored-by: fisx <10210727+fisx@users.noreply.github.com>
…y type annotation Co-authored-by: fisx <10210727+fisx@users.noreply.github.com>
Copilot
AI
changed the title
[WPB-23644] [WIP] Update golden JSON fixtures for changed Haskell data type
[WPB-23644] Add Mar 3, 2026
teamContactUserType field to TeamContact and fix golden JSON fixtures
…fix-subsystems-dep-graph Co-authored-by: fisx <10210727+fisx@users.noreply.github.com>
Contributor
Author
Done. Reverted all Haskell source changes (commit |
Copilot
AI
changed the title
[WPB-23644] Add
[WPB-23644] Fix golden JSON fixtures for Mar 3, 2026
teamContactUserType field to TeamContact and fix golden JSON fixturesTeamContact (based on WPB-23644-fix-subsystems-dep-graph)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The golden JSON fixtures for
TeamContactandSearchResult TeamContactwere missing the required"type"field (regular/app/bot) introduced by the schema change in #5074. This PR is intended to be merged on top of branchWPB-23644-fix-subsystems-dep-graphand adds only the fixture updates.Changes
Golden fixtures
testObject_TeamContact_user_*.json: Added"type": "regular"testObject_SearchResult_20TeamContact_user_*.json: Added"type"per contact ("app"for first contact in fixture 1,"regular"elsewhere)Checklist
changelog.dOriginal prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.