Skip to content

[WPB-23644] Fix golden JSON fixtures for TeamContact (based on WPB-23644-fix-subsystems-dep-graph)#5082

Draft
Copilot wants to merge 4 commits intodevelopfrom
copilot/update-golden-json-fixtures
Draft

[WPB-23644] Fix golden JSON fixtures for TeamContact (based on WPB-23644-fix-subsystems-dep-graph)#5082
Copilot wants to merge 4 commits intodevelopfrom
copilot/update-golden-json-fixtures

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

The golden JSON fixtures for TeamContact and SearchResult TeamContact were missing the required "type" field (regular/app/bot) introduced by the schema change in #5074. This PR is intended to be merged on top of branch WPB-23644-fix-subsystems-dep-graph and adds only the fixture updates.

Changes

Golden fixtures

  • All 20 testObject_TeamContact_user_*.json: Added "type": "regular"
  • All 20 testObject_SearchResult_20TeamContact_user_*.json: Added "type" per contact ("app" for first contact in fixture 1, "regular" elsewhere)

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines
Original prompt

We need to update golden JSON fixtures in wire-server repo because Haskell data type changed. Broken golden tests in libs/wire-api/test/golden/Test/Wire/API/Golden/Generated/SearchResult_20TeamContact_user.hs and TeamContact_user.hs. Schema now requires field "type" = "regular" (or "app" or "bot") in JSON fixtures representing users/contacts.

Task:

  1. Create a PR based on current branch of PR https://github.com/wireapp/wire-server/pull/5074/changes (use that branch as base).
  2. Identify all affected golden JSON files (fixtures) in libs/wire-api/test/golden (and anywhere else) that represent the changed type and are missing "type".
  3. Update each affected JSON file to include new "type" field with correct value (regular/app/bot) according to fixture context.
  4. Run tests: make c package=wire-api test=1 (or an equivalent command) and ensure all golden tests pass.
  5. Commit changes and open PR.

Notes:

  • Ensure JSON ordering matches expected golden generation if required.
  • Update both SearchResult_20TeamContact_user-related fixtures and TeamContact_user fixtures.
  • If there are multiple instances of user/contact schemas, update accordingly.

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI assigned Copilot and fisx Mar 3, 2026
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 3, 2026
@fisx
Copy link
Contributor

fisx commented Mar 3, 2026

@copilot stop! please change this PR to be based on branch WPB-23644-fix-subsystems-dep-graph, that'll save you a lot of work!

@fisx fisx changed the title [WIP] Update golden JSON fixtures for changed Haskell data type [WPB-23644] [WIP] Update golden JSON fixtures for changed Haskell data type Mar 3, 2026
Copilot AI and others added 2 commits March 3, 2026 16:15
…factor inferUserType

Co-authored-by: fisx <10210727+fisx@users.noreply.github.com>
…y type annotation

Co-authored-by: fisx <10210727+fisx@users.noreply.github.com>
Copilot AI changed the title [WPB-23644] [WIP] Update golden JSON fixtures for changed Haskell data type [WPB-23644] Add teamContactUserType field to TeamContact and fix golden JSON fixtures Mar 3, 2026
Copilot finished work on behalf of fisx March 3, 2026 16:20
…fix-subsystems-dep-graph

Co-authored-by: fisx <10210727+fisx@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 3, 2026

@copilot stop! please change this PR to be based on branch WPB-23644-fix-subsystems-dep-graph, that'll save you a lot of work!

Done. Reverted all Haskell source changes (commit 240ca44) — this PR now only contains the JSON fixture updates. Please change the base branch to WPB-23644-fix-subsystems-dep-graph so the diff is clean.

Copilot AI changed the title [WPB-23644] Add teamContactUserType field to TeamContact and fix golden JSON fixtures [WPB-23644] Fix golden JSON fixtures for TeamContact (based on WPB-23644-fix-subsystems-dep-graph) Mar 3, 2026
Copilot finished work on behalf of fisx March 3, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants