Skip to content

Draft: open file collabora(WPB-22465)#20254

Open
arjita-mitra wants to merge 2 commits intodevfrom
feat/open-file-collabora-WPB-22465
Open

Draft: open file collabora(WPB-22465)#20254
arjita-mitra wants to merge 2 commits intodevfrom
feat/open-file-collabora-WPB-22465

Conversation

@arjita-mitra
Copy link
Contributor

@arjita-mitra arjita-mitra commented Jan 30, 2026

TaskWPB-22465 [Web] Add the option to create a new Collabora document from files tab

Pull Request

Summary

  • What did I change and why?
  • Risks and how to roll out / roll back (e.g. feature flags):

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 3.19149% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.09%. Comparing base (8c365de) to head (7125d74).
⚠️ Report is 12 commits behind head on dev.

Files with missing lines Patch % Lines
...p/src/script/repositories/cells/CellsRepository.ts 0.00% 30 Missing ⚠️
.../common/useCellsNewNodeForm/useCellsNewNodeForm.ts 0.00% 20 Missing ⚠️
...llsNewMenu/CellsNewItemModal/CellsNewItemModal.tsx 0.00% 10 Missing ⚠️
...sation/ConversationCells/CellsTable/CellsTable.tsx 0.00% 10 Missing ⚠️
...nversation/ConversationCells/ConversationCells.tsx 0.00% 8 Missing ⚠️
libraries/api-client/src/cells/CellsAPI.ts 0.00% 5 Missing and 2 partials ⚠️
...Cells/common/CellsNewNodeForm/CellsNewNodeForm.tsx 25.00% 3 Missing ⚠️
...ents/FileFullscreenModal/FileEditor/FileEditor.tsx 0.00% 2 Missing ⚠️
...ionCells/CellsHeader/CellsNewMenu/CellsNewMenu.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #20254      +/-   ##
==========================================
- Coverage   45.16%   45.09%   -0.08%     
==========================================
  Files        1633     1633              
  Lines       40199    40267      +68     
  Branches     8311     8338      +27     
==========================================
+ Hits        18157    18159       +2     
- Misses      20114    20178      +64     
- Partials     1928     1930       +2     
Flag Coverage Δ
app_webapp 43.25% <3.44%> (-0.08%) ⬇️
lib_api_client 50.15% <0.00%> (-0.13%) ⬇️
lib_core 58.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...common/CellsNewNodeForm/CellsNewNodeForm.styles.ts 100.00% <100.00%> (ø)
...ionCells/CellsHeader/CellsNewMenu/CellsNewMenu.tsx 7.69% <0.00%> (-0.65%) ⬇️
...ents/FileFullscreenModal/FileEditor/FileEditor.tsx 4.25% <0.00%> (-0.19%) ⬇️
...Cells/common/CellsNewNodeForm/CellsNewNodeForm.tsx 12.50% <25.00%> (-7.50%) ⬇️
libraries/api-client/src/cells/CellsAPI.ts 63.58% <0.00%> (-2.69%) ⬇️
...nversation/ConversationCells/ConversationCells.tsx 5.12% <0.00%> (ø)
...llsNewMenu/CellsNewItemModal/CellsNewItemModal.tsx 6.66% <0.00%> (-7.62%) ⬇️
...sation/ConversationCells/CellsTable/CellsTable.tsx 7.14% <0.00%> (ø)
.../common/useCellsNewNodeForm/useCellsNewNodeForm.ts 4.08% <0.00%> (-1.98%) ⬇️
...p/src/script/repositories/cells/CellsRepository.ts 5.95% <0.00%> (-3.14%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 140
  • Failed: 4
  • Skipped: 12
  • 🔁 Flaky: 3
  • 📊 Total: 159
  • Total Runtime: 370.8s (~ 6 min 11 sec)
specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/Authentication/authentication.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Authentication > Make sure user does not see data of user of previous sessions on same browser (tags: TC-1311, regression)
specs/ClearConversationContent/clearConversationContent.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Clear Conversation Content > I want to clear the 1:1 conversation content from conversation details options (tags: TC-425, regression)
specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ 1:1 Video call with device switch and screenshare (tags: TC-8754, crit-flow-web)
specs/Delete/delete.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Delete > I cannot delete certain types of messages (system messages) (tags: TC-571, regression)
specs/Reactions/reactions.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Reactions > I want to add/remove a reaction using emoji picker (tags: TC-1549, regression)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants