feat: Add hardware acceleration toggle with restart confirmation (Desktop only) [WPB-22425]#20441
Open
EnricoSchw wants to merge 4 commits intodevfrom
Open
feat: Add hardware acceleration toggle with restart confirmation (Desktop only) [WPB-22425]#20441EnricoSchw wants to merge 4 commits intodevfrom
EnricoSchw wants to merge 4 commits intodevfrom
Conversation
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/conversationManagement-TC-8636.spec.ts (❌ 0 failed,
|
zskhan
requested changes
Feb 19, 2026
| return window.desktopAppConfig; | ||
| }, | ||
| getDesktopSettings: () => { | ||
| if (!Runtime.isDesktopApp) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!Runtime.isDesktopApp) { | |
| if (!Runtime.isDesktopApp()) { |
| <Checkbox | ||
| onChange={handleHardwareAccelerationChange} | ||
| checked={hardwareAccelerationEnabled} | ||
| data-uie-name="status-preference-hardware-acceleration" |
Contributor
There was a problem hiding this comment.
the htmlFor attribute in the CheckboxLabel looks for id in the Checkbox
Suggested change
| data-uie-name="status-preference-hardware-acceleration" | |
| id="status-preference-hardware-acceleration" data-uie-name="status-preference-hardware-acceleration" |
|
|
||
| setShowHwRestartModal(false); | ||
|
|
||
| amplify.publish(WebAppEvents.LIFECYCLE.RESTART); |
Contributor
There was a problem hiding this comment.
if restart is delayed then pendingHwValue will be stale
Suggested change
| amplify.publish(WebAppEvents.LIFECYCLE.RESTART); | |
| amplify.publish(WebAppEvents.LIFECYCLE.RESTART); | |
| setPendingHwValue(null); |
| 'preferencesOptionsEmojiReplaceDetail': `:-) → [icon]`; | ||
| 'preferencesOptionsEnableAgcCheckbox': `Automatic gain control (AGC)`; | ||
| 'preferencesOptionsEnableAgcDetails': `Enable to allow your microphone volume to be adjusted automatically to ensure all participants in a call are heard with similar and comfortable loudness.`; | ||
| 'preferencesOptionsEnableHardwareAcceleration': `Enable Hardware Acceleration (Recommended)`; |
Contributor
There was a problem hiding this comment.
These keys must also be added in the en-US.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Summary
This PR introduces a hardware acceleration toggle in the Call Preferences (Desktop only).
Since hardware acceleration can only be applied during application startup, changing this setting now requires a restart. A confirmation modal is shown before applying the change.
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers