Skip to content

test: implement regression tests for in conversation search [WPB-19955]#20492

Open
JacquelineLehner wants to merge 6 commits intodevfrom
19955-in-conversation-search
Open

test: implement regression tests for in conversation search [WPB-19955]#20492
JacquelineLehner wants to merge 6 commits intodevfrom
19955-in-conversation-search

Conversation

@JacquelineLehner
Copy link
Collaborator

@JacquelineLehner JacquelineLehner commented Feb 23, 2026 •
edited by github-actions bot
Loading

TaskWPB-19955 [Web/QA] Write the In Conversation Search regression tests in Playwright

Pull Request

Summary

  • add regression tests for in conversation search

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)

Screenshots or demo (if the user interface changed)

Notes for reviewers

Code duplication cannot be reduced any further since it's log in of the users.

@JacquelineLehner JacquelineLehner marked this pull request as draft February 23, 2026 12:13
@codecov
Copy link

codecov bot commented Feb 23, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.48%. Comparing base (0d75332) to head (0246d71).

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #20492      +/-   ##
==========================================
- Coverage   45.48%   45.48%   -0.01%     
==========================================
  Files        1640     1640              
  Lines       40430    40430              
  Branches     8349     8349              
==========================================
- Hits        18391    18390       -1     
  Misses      20102    20102              
- Partials     1937     1938       +1
Flag Coverage Δ
app_webapp 43.70% <ø> (-0.01%) ⬇️
lib_api_client 50.17% <ø> (ø)
lib_core 59.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026 •
edited
Loading

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • ✅ Passed: 194
  • ❌ Failed: 0
  • ⏭ Skipped: 15
  • 🔁 Flaky: 9
  • 📊 Total: 218
  • ⏱ Total Runtime: 311.0s (~ 5 min 11 sec)
specs/AppLock/AppLock.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ AppLock > I should not be able to switch off app lock if it is enforced for the team (tags: TC-2770, TC-2767, regression)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/Authentication/authentication.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Authentication > Make sure user does not see data of user of previous sessions on same browser (tags: TC-1311, regression)
specs/Block/block.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Block: User A and User B are NOT in the same team > Verify you can block a user who is not in your team (tags: TC-140, regression)
specs/Delete/delete.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Delete > Deleted messages remain deleted after I archive and unarchive the conversation (tags: TC-572, regression)
specs/Markdown/markdown.spec.ts (❌ 0 failed, ⚠️ 2 flaky)
  • ⚠️ Markdown > I want to write a code message (tags: TC-1315, regression)
  • ⚠️ Markdown > I want to write a mixed markdown message (tags: TC-1317, regression)
specs/ParticipantProfile/participantProfile.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Participant Profile > I want to see Remove from group as an admin seeing a participants profile (tags: TC-1487, regression)
specs/Reply/reply.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Reply > I want to reply with mention and tap on the mention in the reply opens the user profile (tags: TC-3016, regression)

markbrockhoff
markbrockhoff requested changes Feb 23, 2026
View reviewed changes
@JacquelineLehner JacquelineLehner force-pushed the 19955-in-conversation-search branch 2 times, most recently from d3708aa to bf4f612 Compare March 2, 2026 09:53
@JacquelineLehner JacquelineLehner marked this pull request as ready for review March 2, 2026 09:54
markbrockhoff
markbrockhoff requested changes Mar 2, 2026
View reviewed changes
@JacquelineLehner
wip
194a751
@JacquelineLehner
still wip
6821189
@JacquelineLehner
test(in-conversation-search): add regression tests for search and med…
de18ac7 
…ia collection

This commit introduces a new test suite to verify the in-conversation
search and media collection functionality.

Implemented scenarios include:
- Verifying the media overview for images, audio, and files
  (@TC-352, @TC-356, @TC-357, @TC-359).
- Searching for specific messages, links, and special characters,
  as well as testing search string trimming (@TC-385, @TC-391,
  @TC-398, @TC-403, @TC-405).
- Verifying that clicking a search result scrolls the relevant message
  into view (@TC-408).
- Ensuring deleted messages and media do not appear in search results
  or the media collection (@TC-360, @TC-392).

Note: Tests @TC-358 (overview of all links) and @TC-388 (text mixed
with link preview) are currently skipped due to the known bug
[WPB-22484].

Refs: WPB-19955
@JacquelineLehner
test(in-conversation-search): refactor test suite based on review com…
537aeaf 
…ments

This commit introduces a new test suite to verify the in-conversation
search and media collection functionality.

Implemented scenarios include:
- Verifying the media overview for images, audio, and files
  (@TC-352, @TC-356, @TC-357, @TC-359).
- Searching for specific messages, links, and special characters,
  as well as testing search string trimming (@TC-385, @TC-391,
  @TC-398, @TC-403, @TC-405).
- Verifying that clicking a search result scrolls the relevant message
  into view (@TC-408).
- Ensuring deleted messages and media do not appear in search results
  or the media collection (@TC-360, @TC-392).

Note: Tests @TC-358 (overview of all links) and @TC-388 (text mixed
with link preview) are currently skipped due to the known bug
[WPB-22484].

Refs: WPB-19955
@JacquelineLehner
test(in-conversation-search): fixed, using new createTeam fixture
540a9cd 
This commit introduces a new test suite to verify the in-conversation
search and media collection functionality.

Implemented scenarios include:
- Verifying the media overview for images, audio, and files
  (@TC-352, @TC-356, @TC-357, @TC-359).
- Searching for specific messages, links, and special characters,
  as well as testing search string trimming (@TC-385, @TC-391,
  @TC-398, @TC-403, @TC-405).
- Verifying that clicking a search result scrolls the relevant message
  into view (@TC-408).
- Ensuring deleted messages and media do not appear in search results
  or the media collection (@TC-360, @TC-392).

Note: Tests @TC-358 (overview of all links) and @TC-388 (text mixed
with link preview) are currently skipped due to the known bug
[WPB-22484].

Refs: WPB-19955
@JacquelineLehner
test(in-conversation-search): refactored, according to review comments
0246d71 
This commit introduces a new test suite to verify the in-conversation
search and media collection functionality.

Implemented scenarios include:
- Verifying the media overview for images, audio, and files
  (@TC-352, @TC-356, @TC-357, @TC-359).
- Searching for specific messages, links, and special characters,
  as well as testing search string trimming (@TC-385, @TC-391,
  @TC-398, @TC-403, @TC-405).
- Verifying that clicking a search result scrolls the relevant message
  into view (@TC-408).
- Ensuring deleted messages and media do not appear in search results
  or the media collection (@TC-360, @TC-392).

Note: Tests @TC-358 (overview of all links) and @TC-388 (text mixed
with link preview) are currently skipped due to the known bug
[WPB-22484].

Refs: WPB-19955
@JacquelineLehner JacquelineLehner force-pushed the 19955-in-conversation-search branch from bf4f612 to 0246d71 Compare March 3, 2026 08:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
23.5% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markbrockhoff markbrockhoff markbrockhoff approved these changes

@arjita-mitra arjita-mitra Awaiting requested review from arjita-mitra arjita-mitra is a code owner

@e-maad e-maad Awaiting requested review from e-maad e-maad is a code owner

@mathias-niboulies mathias-niboulies Awaiting requested review from mathias-niboulies mathias-niboulies is a code owner

@nkaramarko nkaramarko Awaiting requested review from nkaramarko nkaramarko is a code owner

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

@screendriver screendriver Awaiting requested review from screendriver screendriver is a code owner

@thisisamir98 thisisamir98 Awaiting requested review from thisisamir98 thisisamir98 is a code owner

@V-Gira V-Gira Awaiting requested review from V-Gira V-Gira is a code owner

@zskhan zskhan Awaiting requested review from zskhan zskhan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

app: webapp 👕 size: L type: test 👷

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JacquelineLehner @markbrockhoff @otto-the-bot