test: add mention regression tests [WPB-19960]#20498
test: add mention regression tests [WPB-19960]#20498markbrockhoff wants to merge 24 commits intodevfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #20498 +/- ##
=======================================
Coverage 45.49% 45.49%
=======================================
Files 1640 1640
Lines 40433 40433
Branches 8349 8347 -2
=======================================
+ Hits 18394 18395 +1
Misses 20102 20102
+ Partials 1937 1936 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/Mention/mention.spec.ts (❌ 0 failed,
|
27eb76f to
6aa7697
Compare
4a47a4a to
49a706a
Compare
| className="call-ui__button call-ui__button--red call-ui__button--large" | ||
| onClick={() => (isIncoming ? callActions.reject(call) : callActions.leave(call))} | ||
| onBlur={() => clearShowAlert()} | ||
| title={!isGroup && showAlert ? call1To1StartedAlert : t('videoCallOverlayHangUp')} |
There was a problem hiding this comment.
The call1To1StartedAlert message is already placed on the calling cell itself. It should not be used as title / label of a button since it just says e.g. "You are calling {conversationName}." which adds no accessible meaning to a button and makes it even less accessible. So I removed it in favor for the descriptive label describing the button to hang up which is what it's doing.
| use: { | ||
| ...devices['Desktop Chrome'], | ||
| permissions: ['notifications'], | ||
| permissions: ['notifications', 'clipboard-read', 'clipboard-write'], |
There was a problem hiding this comment.
Turns out it's not possible to create a guest link if the browser doesn't have clipboard permission...
After setting a password a modal is forced on you to copy the password. If the user doesn't copy it or the browser can't write to the clipboard it will just fail and do nothing.
569ea74 to
6a1d8b2
Compare
|


Pull Request
Summary
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Notes for reviewers