Skip to content

fix: Conversation images previews do not seem to use actual server-provided previews, but original image(WPB-22331)#20567

Open
arjita-mitra wants to merge 3 commits intodevfrom
bugfix/image-preview-WPB-22331
Open

fix: Conversation images previews do not seem to use actual server-provided previews, but original image(WPB-22331)#20567
arjita-mitra wants to merge 3 commits intodevfrom
bugfix/image-preview-WPB-22331

Conversation

@arjita-mitra
Copy link
Contributor

@arjita-mitra arjita-mitra commented Mar 4, 2026

BugWPB-22331 [Web] Conversation images previews do not seem to use actual server-provided previews, but original image

Pull Request

Summary

  • Small image cards (multiple images in one message): continue using src={filePreviewUrl} correct for grid display, no change.

  • Large image cards (single image in a message): now use the original fileUrl, falling back to filePreviewUrl only if unavailable.

  • Fullscreen viewer: now uses the original fileUrl instead of the thumbnail.

HEIC handling

HEIC files uploaded from iOS cannot be decoded natively by Chrome, Firefox, or Edge. For these files, isPreviewableImage({extension}) returns false, so both the large card and fullscreen fall back to filePreviewUrl the server-generated JPEG conversion which is safe across all browsers. The original HEIC file is still accessible via the download button in the fullscreen header.


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

…ovided previews, but original image(WPB-22331)
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 10
  • Failed: 0
  • Skipped: 3
  • 🔁 Flaky: 1
  • 📊 Total: 14
  • Total Runtime: 96.8s (~ 1 min 37 sec)
specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Team owner adds whole team to an all team chat (tags: TC-8631, crit-flow-web)

…urce pure function this makes jest.mock redundant
Co-authored-by: Christian Rackerseder <git@echooff.de>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants