refactor: remove generation of types for translations [WPB-22420]#20568
Closed
markbrockhoff wants to merge 1 commit intodevfrom
Closed
refactor: remove generation of types for translations [WPB-22420]#20568markbrockhoff wants to merge 1 commit intodevfrom
markbrockhoff wants to merge 1 commit intodevfrom
Conversation
markbrockhoff
changed the title
Generating the types out of a json file is redundant since resolveJsonModule is available in typescript and enabled for this repository. Type checking continues to work as safely as before with no need for generating the types or checking whether they were modified or not in CI.
markbrockhoff
force-pushed
the
mb/remove-i18n-types-generation
branch
from
62976ef to
5da1775
Compare
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/accountManagement-TC-8639.spec.ts (❌ 0 failed,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Generating the types out of a json file is redundant since resolveJsonModule is available in typescript and enabled for this repository. Type checking continues to work as safely as before with no need for generating the types or checking whether they were modified or not in CI.
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)