Skip to content

test: add conversations regression tests [WPB-19946]#20584

Merged
markbrockhoff merged 4 commits intodevfrom
test/WPB-19946-write-the-conversations-regression-tests
Mar 9, 2026
Merged

test: add conversations regression tests [WPB-19946]#20584
markbrockhoff merged 4 commits intodevfrom
test/WPB-19946-write-the-conversations-regression-tests

Conversation

@zhannach
Copy link
Collaborator

@zhannach zhannach commented Mar 5, 2026

TaskWPB-19946 [Web/QA] Write the Conversations regression tests in Playwright

Pull Request

Summary

Add conversations regression tests


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 211
  • Failed: 2
  • Skipped: 13
  • 🔁 Flaky: 11
  • 📊 Total: 237
  • Total Runtime: 454.8s (~ 7 min 35 sec)
specs/2FA-for-TeamsSpecs/2fa-for-teams.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ f2a for teams > 2FA Code (tags: TC-8749, regression)
specs/Authentication/authentication.spec.ts (❌ 1 failed, ⚠️ 1 flaky)
  • ❌ Authentication > Make sure user does not see data of user of previous sessions on same browser (tags: TC-1311, regression)
  • ⚠️ Authentication > Verify current browser is set as temporary device (tags: TC-3460, regression)
specs/Block/block.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Block: User A and User B are NOT in the same team > Verify you can unblock someone from conversation list options (tags: TC-148, regression)
specs/Conversations/conversations.spec.ts (❌ 0 failed, ⚠️ 2 flaky)
  • ⚠️ Conversations > I want to see a system message with all group members mentioned when I create a group (tags: TC-2965, regression)
  • ⚠️ Conversations > I can see the system message "You renamed the conversation" after renaming conversation (tags: TC-496, regression)
specs/CriticalFlow/groupCalls-TC-8632.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)
specs/CriticalFlow/messagesInChannels-TC-8753.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Messages in Channels (tags: TC-8753, crit-flow-web)
specs/CriticalFlow/messagesInGroups-TC-8751.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Messages in Groups (tags: TC-8751, crit-flow-web)
specs/Markdown/markdown.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Markdown > I want to write a url with markdown (Mixed with text) (tags: TC-1319, regression)
specs/Notifications/notifications.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Notifications > I want to receive notifications for mentions (tags: TC-3499, regression)
specs/SelfDeletingMessages/selfDeletingMessages.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Self Deleting Messages > Verify the message is not deleted for users that didn't read the message (tags: TC-675, regression)
specs/Status/status.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Status > When I am away, I should not get any notifications (tags: TC-3608, regression)

Copy link
Collaborator

@thisisamir98 thisisamir98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this PR is too large to review, can you split it to multiple smaller PRs please?

@zhannach zhannach force-pushed the test/WPB-19946-write-the-conversations-regression-tests branch from dbc082d to 70e0943 Compare March 6, 2026 14:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
7.0% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@zhannach
Copy link
Collaborator Author

zhannach commented Mar 9, 2026

Hi, this PR is too large to review, can you split it to multiple smaller PRs please?

I see your point. I opted for an atomic approach here because the tests are closely linked, and I wanted to avoid dependency issues between multiple PRs. I'll keep this in mind for future tasks.

@zhannach zhannach enabled auto-merge March 9, 2026 11:51
@markbrockhoff markbrockhoff disabled auto-merge March 9, 2026 13:09
@markbrockhoff markbrockhoff added this pull request to the merge queue Mar 9, 2026
Merged via the queue into dev with commit ac95a67 Mar 9, 2026
15 of 16 checks passed
@markbrockhoff markbrockhoff deleted the test/WPB-19946-write-the-conversations-regression-tests branch March 9, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants