test: add conversations regression tests [WPB-19946]#20584
Merged
markbrockhoff merged 4 commits intodevfrom Mar 9, 2026
Merged
test: add conversations regression tests [WPB-19946]#20584markbrockhoff merged 4 commits intodevfrom
markbrockhoff merged 4 commits intodevfrom
Conversation
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/2FA-for-TeamsSpecs/2fa-for-teams.spec.ts (❌ 0 failed,
|
thisisamir98
reviewed
Mar 6, 2026
Collaborator
thisisamir98
left a comment
There was a problem hiding this comment.
Hi, this PR is too large to review, can you split it to multiple smaller PRs please?
markbrockhoff
requested changes
Mar 6, 2026
apps/webapp/test/e2e_tests/specs/Conversations/conversations.spec.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/specs/Conversations/conversations.spec.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/specs/Conversations/conversations.spec.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/pageManager/webapp/pages/conversationDetails.page.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/specs/Conversations/conversations.spec.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/specs/Conversations/conversations.spec.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/specs/Conversations/conversations.spec.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/specs/Conversations/conversations.spec.ts
Outdated
Show resolved
Hide resolved
dbc082d to
70e0943
Compare
|
markbrockhoff
approved these changes
Mar 6, 2026
Collaborator
Author
I see your point. I opted for an atomic approach here because the tests are closely linked, and I wanted to avoid dependency issues between multiple PRs. I'll keep this in mind for future tasks. |
zskhan
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull Request
Summary
Add conversations regression tests
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers