Skip to content

refactor(webapp): clarify deterministic time control naming in tests [WPB-23299]#20586

Merged
screendriver merged 1 commit intodevfrom
clock
Mar 6, 2026
Merged

refactor(webapp): clarify deterministic time control naming in tests [WPB-23299]#20586
screendriver merged 1 commit intodevfrom
clock

Conversation

@screendriver
Copy link
Member

@screendriver screendriver commented Mar 6, 2026

TaskWPB-23299 [Web] Add support for remote force reload

Pull Request

Summary

Replace "fake wall clock" terminology with "deterministic wall clock" to make the test-time semantics explicit and consistent across the webapp test suite.


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

thisisamir98
thisisamir98 previously approved these changes Mar 6, 2026
nkaramarko
nkaramarko previously approved these changes Mar 6, 2026
arjita-mitra
arjita-mitra previously approved these changes Mar 6, 2026
@screendriver screendriver added this pull request to the merge queue Mar 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 6, 2026
Replace "fake wall clock" terminology with "deterministic wall clock" to
make the test-time semantics explicit and consistent across the webapp
test suite.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

@screendriver screendriver enabled auto-merge March 6, 2026 08:26
@screendriver screendriver added this pull request to the merge queue Mar 6, 2026
Merged via the queue into dev with commit 068e870 Mar 6, 2026
52 checks passed
@screendriver screendriver deleted the clock branch March 6, 2026 08:32
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 10
  • Failed: 0
  • Skipped: 3
  • 🔁 Flaky: 1
  • 📊 Total: 14
  • Total Runtime: 84.0s (~ 1 min 24 sec)
specs/CriticalFlow/conversationManagement-TC-8636.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Conversation Management (tags: TC-8636, crit-flow-web)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants