feat(websocket-connection): add isolated online/offline state machine [WPB-23826]#20588
Merged
screendriver merged 2 commits intodevfrom Mar 6, 2026
Merged
feat(websocket-connection): add isolated online/offline state machine [WPB-23826]#20588screendriver merged 2 commits intodevfrom
screendriver merged 2 commits intodevfrom
Conversation
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #20588 +/- ##
=======================================
Coverage 45.58% 45.58%
=======================================
Files 1641 1642 +1
Lines 40496 40499 +3
Branches 8354 8354
=======================================
+ Hits 18461 18463 +2
Misses 20097 20097
- Partials 1938 1939 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Did you consider weblegions ts-fsm over xstate? Recently read about ts-fsm and thought it was probably a good way to to go. Either way big fan of FSMs, so, this should serve as a great example on how ensure strict state transitions moving forward. +1 |
Member
Author
Yes, I know |
zskhan
previously approved these changes
Mar 6, 2026
zskhan
approved these changes
Mar 6, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
Summary
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers