Skip to content

Guard malformed dupes and stale ghosts - #544

Open
ShiroKSH wants to merge 1 commit into
wiremod:masterfrom
ShiroKSH:fix/ghost-codec-guards
Open

Guard malformed dupes and stale ghosts#544
ShiroKSH wants to merge 1 commit into
wiremod:masterfrom
ShiroKSH:fix/ghost-codec-guards

Conversation

@ShiroKSH

@ShiroKSH ShiroKSH commented Jul 8, 2026

Copy link
Copy Markdown

Summary

  • Guard ghost setup against invalid head ghost data and failed clientside model creation.
  • Keep add-one ghost updates from indexing stale ghost state.
  • Return decode errors for malformed dupe tables and invalid JSON conversion input.

Testing

  • glualint 1.29.0 on lua/advdupe2/sh_codec.lua and lua/advdupe2/cl_ghost.lua
  • git diff --check

@ShiroKSH
ShiroKSH marked this pull request as ready for review July 8, 2026 16:53
Comment thread lua/advdupe2/cl_ghost.lua
@ShiroKSH

Copy link
Copy Markdown
Author

@Astralcircle - thegrb93 approved this PR, and the branch is clean. Could you take the final maintainer pass when you have a chance? I can make any requested changes. Thanks!

@thegrb93

Copy link
Copy Markdown

I didn't fully review or test the code btw. Just looked it over for fatal issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants