Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Verify DraftJS inputs#3049

Closed
mxstbr wants to merge 2 commits intoalphafrom
api-raw-draft-content-state
Closed

Verify DraftJS inputs#3049
mxstbr wants to merge 2 commits intoalphafrom
api-raw-draft-content-state

Conversation

@mxstbr
Copy link
Contributor

@mxstbr mxstbr commented May 9, 2018

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • api

This verifies that input marked as being raw DraftJS content state is actual raw DraftJS content state. /cc @flarnie is there any chance DraftJS will expose a isRawDraftContentState(value) API itself sometime?

@brianlovin
Copy link
Contributor

@mxstbr happy to approve this, but were you still waiting to get more feedback on this from Flarnie?

@mxstbr
Copy link
Contributor Author

mxstbr commented May 24, 2018

This needs some more work from my side to not break the API like we did with LowercaseString.

return true;
};

const RawDraftContentState = new GraphQLScalarType({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's so cool! i quite no idea how to handle serialize JSON in GraphQL schema, until now😋

@mxstbr
Copy link
Contributor Author

mxstbr commented Feb 12, 2019

This is no longer necessary as of #4472 and #4564

@mxstbr mxstbr closed this Feb 12, 2019
@mxstbr mxstbr deleted the api-raw-draft-content-state branch February 12, 2019 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants