-
Notifications
You must be signed in to change notification settings - Fork 747
Progress Bar corner radius #3898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for custom corner radius on the ProgressBar component by introducing new styling props. The changes deprecate the existing style and progressColor props in favor of more semantic containerStyle and progressStyle props, allowing users to customize both the outer container and inner progress bar independently.
- Introduced
containerStyleandprogressStyleprops to replacestyleandprogressColor - Updated demo screen to showcase custom border radius configurations
- Updated API documentation to reflect the new prop names
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/react-native-ui-lib/src/components/progressBar/progressBar.api.json | Updated API documentation replacing style with containerStyle and progressColor with progressStyle |
| packages/react-native-ui-lib/src/components/progressBar/index.tsx | Added new containerStyle and progressStyle props with deprecation warnings for old props; refactored render method to use new props |
| demo/src/screens/componentScreens/ProgressBarScreen.tsx | Updated demo to showcase new styling capabilities including custom border radius examples; cleaned up formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-native-ui-lib/src/components/progressBar/index.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-ui-lib/src/components/progressBar/progressBar.api.json
Show resolved
Hide resolved
packages/react-native-ui-lib/src/components/progressBar/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
M-i-k-e-l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MIchaelZablianov
Some general comments:
Do not include private links in the public repo (Ticket 4930 is enough).
The changelog is what the user will see - it should generally be a oneliner
The description is what the reviewer reads in order to understand the change
Please do not resolve the reviewer's comments - they are the way I know what was completed and what was not (you can and should resolve co-pilot's comments)
Description
Added progressStyle prop to support custom style of the inner progress and also added
containerStyle prop for the style of the outer container of the progress.
(style is now deprecated as user should use containerStyle).
Changelog
ProgressBar - support progressStyle
Additional info
Ticket 4930