Skip to content

Conversation

@MIchaelZablianov
Copy link
Collaborator

@MIchaelZablianov MIchaelZablianov commented Dec 30, 2025

Description

Added progressStyle prop to support custom style of the inner progress and also added
containerStyle prop for the style of the outer container of the progress.
(style is now deprecated as user should use containerStyle).

Changelog

ProgressBar - support progressStyle

Additional info

Ticket 4930

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for custom corner radius on the ProgressBar component by introducing new styling props. The changes deprecate the existing style and progressColor props in favor of more semantic containerStyle and progressStyle props, allowing users to customize both the outer container and inner progress bar independently.

  • Introduced containerStyle and progressStyle props to replace style and progressColor
  • Updated demo screen to showcase custom border radius configurations
  • Updated API documentation to reflect the new prop names

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/react-native-ui-lib/src/components/progressBar/progressBar.api.json Updated API documentation replacing style with containerStyle and progressColor with progressStyle
packages/react-native-ui-lib/src/components/progressBar/index.tsx Added new containerStyle and progressStyle props with deprecation warnings for old props; refactored render method to use new props
demo/src/screens/componentScreens/ProgressBarScreen.tsx Updated demo to showcase new styling capabilities including custom border radius examples; cleaned up formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MIchaelZablianov and others added 4 commits December 31, 2025 14:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MIchaelZablianov
Some general comments:
Do not include private links in the public repo (Ticket 4930 is enough).
The changelog is what the user will see - it should generally be a oneliner
The description is what the reviewer reads in order to understand the change
Please do not resolve the reviewer's comments - they are the way I know what was completed and what was not (you can and should resolve co-pilot's comments)

@M-i-k-e-l M-i-k-e-l merged commit 52d50a7 into master Jan 5, 2026
1 check passed
@M-i-k-e-l M-i-k-e-l deleted the feat/ProgressBar_progressStyle_support branch January 5, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants