This repository was archived by the owner on Apr 14, 2019. It is now read-only.
Added Regex group matching to allow relative URL redirection#35
Open
skidmow wants to merge 1 commit intowkallhof:masterfrom
Open
Added Regex group matching to allow relative URL redirection#35skidmow wants to merge 1 commit intowkallhof:masterfrom
skidmow wants to merge 1 commit intowkallhof:masterfrom
Conversation
…page-old/child-pages (many) to be directed to /page-new/child-pages (many) in one redirect entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Regex group matching to allow relative URL redirection.
E.g. for the above example you would use:
Old URL: /page-old/?(.*)
New Page: /page-new/$1
This one redirect would result in mappings like so:
/page-old -> /page-new/
/page-old/ -> /page-new/
/page-old/child-page/ -> /page-new/child-page/
/page-old/child-page1/ -> /page-new/child-page1/
/page-old/child-page/descendant-page/ -> /page-new/child-page/descendant-page/
etc.
It means that you can easily rename a parent page and map all the child pages to the new URL.
This change is based on a previous pull request that hasn't been merged and isn't working correctly because they didn't use the newUrl value. See: #32
Also the previous PR included additional functionality for a CustomRedirectContentFinder, which I have omitted from this PR.