Let swayfx-git depend on scenefx-git#35
Conversation
The swayfx git package depends on specific version of scenefx. While this generally works fine. This breaks whenever scenefx-git is installed. Because the provided library may change at any time. Causing issues with swayfx-git still depending on that specific version. To solve this depend on the scenefx-git package instead of the provided library version. This fixes the issue where scenefx-git may install an updated library version that swayfx-git depends on in the same update cycle. The only potential risk with this change is that swayfx-git will break when scenefx-git updates it's library version while not updating swayfx-git. This results in a runtime issue where swayfx-git can't find a specific version of the scenefx library. ref: WillPower3309/swayfx#384 Signed-off-by: Darrel Griët <dgriet@gmail.com>
MagneFire
force-pushed
the
fix/depend-on-git
branch
from
aa5abe5 to
9bd361b
Compare
That is exactly why we haven't done this before. If we update scenefx to a new wlroots version, swayfx won't start. Me and Will have discussed this in the Discord and the alternatives are to either hold back scenefx wlroots version until swayfx gets updated (may take months), or do as we do now |
Is this really an issue though? Take the last two scenefx updates (0.3 and 0.4). They were updated in the following commits:
While swayfx updated its dependencies in the following commits:
The last two library updates to scenefx also required an update to swayfx. This update is automatically installed after scenefx-git is updated because swayfx-git just so happens to always build whenever a new commit is pushed to the swayfx repository. Hence my rationale on why this may not be a huge issue in the real world 😄 Also also, the current approach results in update conflicts (circular dependency) right? This means that manual intervention is required anyway. My goal here is to make the update process more seamless for the
|
|
I've had a change of heart here. You've laid out good justification! |
3 participants
The swayfx git package depends on specific version of scenefx. While this generally works fine. This breaks whenever scenefx-git is installed. Because the provided library may change at any time. Causing issues with swayfx-git still depending on that specific version.
To solve this depend on the scenefx-git package instead of the provided library version. This fixes the issue where scenefx-git may install an updated library version that swayfx-git depends on in the same update cycle.
The only potential risk with this change is that swayfx-git will break when scenefx-git updates it's library version while not updating swayfx-git. This results in a runtime issue where swayfx-git can't find a specific version of the scenefx library.
ref: WillPower3309/swayfx#384