Tooltip Fixes

[sqparadox]

-Fixed triple \n after "Pilot Affinities"
-Because PilotAffinityManager.getPilotToolTip() starts it's return string with \n, "Pilot Affinities:\n" only needs 1 \n to get the presumably desired effect
-Fixed \n before "Pilot Affinities" if Pilot Quirks are enabled but pilot has no quirks
-Fixed \n between Pilot Tag Tooltips and Pilot Quirk Tooltips, to avoid a break between legacy quirks and mechaffinity quirks
-Updated PilotQuirkManager.getPilotToolTip(), PilotQuirkManager.getRoninHiringHallDescription(), and PilotQuirkManager.getRegularHiringHallDescription() with length > 0 checks for Pilot Quirk names and descriptions
-This Allow "hidden" quirks ,ie quirks with name and description set to ""

Current MechAffinity with legacy and MechAffinity pilot quirks and a "hidden" pilot quirk:

Same as above after the updates:

Note: the extra space after the pliot fatigue tag description is from a \n at the end of that tooltipText and is deliberate

[sqparadox]

The explanation behind this is that I'm trying to roughly recreate Don Zappo's pilot quirks with MechAffinity and a custom version of Pilot_Fatigue.

Pilot_Fatigue and a stock version of the PanicSystem mod already cover some of the pilot quirk effects which is why I'm using a mix of legacy and MechAffinity perk descriptions.

The "hidden" quirk is the fatigued when drunk effect. PanicSystem already covers the ejection part. So the simplest way I could cover the rest was to modify my version of Pilot_Fatigue to add a pilot_fatigued_drunk to pilots who have the pilot_drunk tag when they become fatigued. That way the fatigued when drunk effect is only applied when the pilot is also fatigued. But this meant either a double label when the pilot was fatigued or no label when they weren't. Hence the need for a "hidden" quirk
with the tooltip being provided by the legacy "pilot_drunk" tag description.

Below is the json for the pilot_fatigued_drunk effect from my settings file:
{
"tag" : "pilot_fatigued_drunk",
"effectData" : [
{
"Description": {
"Details": "+1 To-Hit",
"Icon": "layeredarmor",
"Id": "StatusEffect-Drunk-ToHit",
"Name": "Fatigued Drunk Accuracy Bonus"
},
"durationData": {
"duration": -1,
"stackLimit": -1
},
"effectType": "StatisticEffect",
"nature": "Buff",
"statisticData": {
"modType": "System.Single",
"modValue": "-1.0",
"operation": "Float_Add",
"statName": "AccuracyModifier",
},
"targetingData": {
"effectTargetType": "Creator",
"effectTriggerType": "Passive",
"hideApplicationFloatie": true,
"showInStatusPanel": false,
"showInTargetPreview": false
}
},
{
"Description": {
"Details": "-1 evasion pips",
"Icon": "UixSvgIcon_specialEquip_System",
"Id": "StatusEffect-Drunk-EvasionLoss",
"Name": "Fatigued Drunk Eeduced Evasion"
},
"durationData": {
"duration": -1,
"stackLimit": -1
},
"effectType": "StatisticEffect",
"nature": "Buff",
"statisticData": {
"additionalRules": "NotSet",
"modType": "System.Int32",
"modValue": "-1",
"operation": "Int_Add",
"statName": "MaxEvasivePips",
"targetAmmoCategory": "NotSet",
"targetCollection": "NotSet",
"targetWeaponCategory": "NotSet",
"targetWeaponSubType": "NotSet",
"targetWeaponType": "NotSet"
},
"targetingData": {
"effectTargetType": "Creator",
"effectTriggerType": "Passive",
"hideApplicationFloatie": true,
"showInStatusPanel": false,
"showInTargetPreview": false
}
}
],
"quirkEffects" : []
}

I'd be happy to share the whole settings file if requested. It has all vanilla tag quirks covered at least to some extent with the exception of pilot_bookish. pliot_command, pilot_officer, plot_rebellious, and pliot_unstable.