Fix PR OSP concurrency collision, add triage PR comments#446
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses GitHub Actions concurrency collisions in reusable workflows under pr-osp-select, and adds automated OSP triage reporting to PRs (in addition to the existing nightly Slack reporting).
Changes:
- Remove
concurrencyself-canceling from the reusablenightly-multi-compiler.ymlandperf-regression.ymlworkflows to prevent sibling-call collisions. - Add a new
lint-workflows.ymlworkflow to fail CI if any reusable workflow setscancel-in-progressto a truthy value. - Extend
osp-report.yml+.github/scripts/osp-triage.pyto triage PR OSP runs and post/update a sticky PR comment.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/perf-regression.yml | Removes reusable-workflow concurrency to avoid cross-call cancellation. |
| .github/workflows/nightly-multi-compiler.yml | Removes reusable-workflow concurrency to avoid cross-call cancellation. |
| .github/workflows/lint-workflows.yml | Adds CI lint to detect reusable workflows that self-cancel. |
| .github/workflows/osp-report.yml | Adds PR OSP run handling, trust gating, PR resolution, and PR commenting support. |
| .github/scripts/osp-triage.py | Adds PR-comment reporting path (GFM rendering + upsert behavior) alongside Slack. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aidangarske
added
ci:all
ColtonWilley
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nightly-multi-compiler.ymlandperf-regression.ymlboth setgroup: ${{ github.workflow }}-${{ github.ref }}. In a reusable workflowgithub.workflowis the caller's name, so underpr-osp-selectbothresolved to the same group and cancelled each other. Every
ci:allrunsilently lost multi-compiler or perf, whichever lost the race.
pr-osp-selectalready collapseslabel bursts.
lint-workflows.yml: fail any reusable workflow withcancel-in-progress: true.osp-report.ymlalso watches PR OSP runs and posts the existing retry +flake-vs-real triage as a sticky PR comment.