Add link for pachorn.dev to index.html#293
Add link for pachorn.dev to index.html#293boomNDS wants to merge 4 commits intowonderfulsoftware:mainfrom
Conversation
📝 WalkthroughWalkthroughAdds a single public-facing webring list item to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@boomNDS Please fix the webring link krub. (Sorry, I was abroad and very busy so did not get time to properly review it.) |
|
@dtinth Done Krub |
|
@boomNDS Hi krub, I checked again, I saw that your website have this: <a href="https://webring.wonderful.software/#/pachorn.dev"It should be: <a href="https://webring.wonderful.software/#pachorn.dev" |
got it i updated my website to used |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@index.html`:
- Around line 448-450: The backlink on the target site must drop the stray slash
before the fragment identifier; update the external backlink that points to
"https://webring.wonderful.software/#pachorn.dev" to
"https://webring.wonderful.software#pachorn.dev" on the target site so the
fragment matches, and ensure the entry with id="pachorn.dev" and the <a
href="https://pachorn.dev"> link remains unchanged here; verify the corrected
URL is served from the target site before merging.
| <li data-lang="en" id="pachorn.dev" data-owner="boomNDS"> | ||
| <a href="https://pachorn.dev">pachorn.dev</a> | ||
| </li> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check the backlink format on pachorn.dev
curl -sL https://pachorn.dev 2>/dev/null | grep -i 'webring.wonderful.software'Repository: wonderfulsoftware/webring
Length of output: 50381
🏁 Script executed:
#!/bin/bash
# Check the webring backlink format on pachorn.dev more specifically
curl -sL https://pachorn.dev 2>/dev/null | grep -oP 'href="https://webring\.wonderful\.software[^"]*"' | head -5Repository: wonderfulsoftware/webring
Length of output: 123
Entry attributes are correct, but backlink format must be fixed before merge.
All required attributes in the index.html entry check out: data-lang="en" is valid, id="pachorn.dev" matches the domain, data-owner="boomNDS" matches the PR author, and the link text matches the id. The entry is properly appended at the end of the list.
However, the backlink on pachorn.dev currently uses https://webring.wonderful.software/#pachorn.dev and must be corrected to https://webring.wonderful.software#pachorn.dev (remove the / before the #). This must be fixed on the target site before merging this PR.
🤖 Prompt for AI Agents
In `@index.html` around lines 448 - 450, The backlink on the target site must drop
the stray slash before the fragment identifier; update the external backlink
that points to "https://webring.wonderful.software/#pachorn.dev" to
"https://webring.wonderful.software#pachorn.dev" on the target site so the
fragment matches, and ensure the entry with id="pachorn.dev" and the <a
href="https://pachorn.dev"> link remains unchanged here; verify the corrected
URL is served from the target site before merging.
PR validation resultBacklink:
Site description:
Screenshot: |



Summary by CodeRabbit