Conversation
amyjko
left a comment
amyjko
left a comment
There was a problem hiding this comment.
Hi @rominaforoudi! I'm just observing that there's no content in our PR notes; just headers with no text. Can you summarize what you've edited here, to help with review?
I also noted a few places where you've removed spaces in the English tutorial. I'm assuming that wasn't intended? Please fix.
| [ | ||
| "FunctionDefinition", | ||
| "eager", | ||
| "Oh yes, there are many others. Some of them are like me: we help choreograph the shows, keeping everyone in their place and making sure we express the vision of our director, exactly as they intended. And some of them are the ones on stage, in front of the audience, dancing and speaking. We all have a role to play!" |
There was a problem hiding this comment.
Why are the spaces removed here?
There was a problem hiding this comment.
This was not on purpose! Sorry about that. Are you able to reject those changes on your end (may be easier than me going in to find them but I can as well). In regards to the PR notes they were hiding for some reason. I fixed it so they show. Apologies for the late update.
| [ | ||
| "Program", | ||
| "excited", | ||
| "I see. Did @FunctionDefinition tell you anything about us? Lots of people try to direct us, but some people get confused, bored, or even irritated with us. We are pretty dense at times. But I'm proud of what we do, so I don't want to work with just anyone." |
There was a problem hiding this comment.
Why are the spaces removed here?
|
PR norms are that you're responsible for submitting a clean set of changes. I can point them out, and you can see them here in GitHub, but it would be your job, not mine, to make sure there aren't any unnecessary changes. |
Alright I will go in and clean it up. Not sure why changes happened in the English. Also I just submitted a new work issue #980 related to our idea on adding some notes/instructions for RTL localization in the localization WIKI. I am going to start working on that today. Let me know what you think! |
rominaforoudi
force-pushed
the
928ReviewArabicLocale
branch
from
a2186e7 to
35c8a7d
Compare
rominaforoudi
force-pushed
the
928ReviewArabicLocale
branch
from
35c8a7d to
406c0c9
Compare
|
Should have fixed the English Locale! Just reverted it back to the original. |
|
Great. Based on your checklist above, I'm reading that this is a draft, and not ready for review and merge yet, correct? I will mark it as a draft. |
|
This is no longer a draft :) |
amyjko
left a comment
amyjko
left a comment
There was a problem hiding this comment.
Almost there! There are some syntax errors in your JSON file.
Run npm run locales ar-SA to see and fix them. There need to be no locale errors in the file before we can merge this.
|
Done! I think? |
|
Looks like you have two conflicts to resolve first. |
|
Fixed the conflicts |
amyjko
left a comment
amyjko
left a comment
There was a problem hiding this comment.
Thank you! I can't provide feedback on the writing since I don't know Arabic, but the community is grateful for your contributions :)
2 participants
Context
Reviewed some of the Arabic Locale!
Related issues
works on #928
Verification
I used my Arabic knowledge split screening with the English locale to compare and rewrite. I learned that VS Code reads left to right because it is built for coding, and programming languages rely on left-to-right structure. In this work, I will examine how this creates problems for right-to-left languages like Arabic (future work issues for credit). I will focus on issues with text direction, cursor movement, and punctuation appearing in the wrong place. I will also address how line and character limits are based on English conventions, which can restrict Arabic writing. This work highlights how left-to-right assumptions limit accessibility for right-to-left locales in tools developed by Microsoft.
Checklist
Remaining steps before this PR is complete:
Complete as much of Arabic translation as possible
Review Arabic text for RTL direction and punctuation issues
Test translations in VS Code using Arabic/RTL support features
Experiment with recommended tools or extensions for Arabic support in VS Code
New Work Issue I need to create!
Document findings and limitations when writing RTL text in an LTR editor
Add notes to the locale wiki with guidance for right-to-left translations
Include best practices and warnings for Arabic and other RTL locales